Build(deps): Bump golang.org/x/term from 0.39.0 to 0.41.0#1045
Build(deps): Bump golang.org/x/term from 0.39.0 to 0.41.0#1045dependabot[bot] wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughGo toolchain requirement bumped from 1.24.13 to 1.25.0; direct dependency Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 3: Update the GitHub Actions workflow jobs that set the go-version to
match go.mod's declared version: change the go-version keys in the
publish-release.yaml and check-pull-request.yaml workflows from older values
(1.22/1.23) to 1.25.0 so CI uses the same Go toolchain as go.mod; search each
workflow for the go-version: entries and replace the value with 1.25.0.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3b82ef9e-33eb-427c-bbeb-d214dcd0b9a1
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| module github.com/openshift-online/ocm-cli | ||
|
|
||
| go 1.24.13 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Checking for Go version pins across common config files..."
rg -n --hidden -g '!go.sum' -g '!.git' -P '\b(go\s+1\.(24|25)(\.\d+)?)\b|go-version\s*:\s*["'\'']?1\.(24|25)(\.\d+)?|FROM\s+golang:1\.(24|25)(\.\d+)?|GO_VERSION\s*[:=]\s*["'\'']?1\.(24|25)(\.\d+)?' .
echo
echo "Checking GitHub Actions setup-go usage..."
rg -n --hidden -g '.github/workflows/*.yml' -g '.github/workflows/*.yaml' -P 'setup-go|go-version' .Repository: openshift-online/ocm-cli
Length of output: 637
Update Go versions in GitHub Actions workflows to match go.mod 1.25.0.
The go module declares go 1.25.0 but CI workflows are pinned to older versions:
.github/workflows/publish-release.yaml(line 45):go-version: 1.23.github/workflows/check-pull-request.yaml(lines 51, 77):go-version: 1.22and1.23
Update both workflows to use go-version: 1.25.0 to match the module's minimum version and ensure CI tests against the correct toolchain.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 3, Update the GitHub Actions workflow jobs that set the
go-version to match go.mod's declared version: change the go-version keys in the
publish-release.yaml and check-pull-request.yaml workflows from older values
(1.22/1.23) to 1.25.0 so CI uses the same Go toolchain as go.mod; search each
workflow for the go-version: entries and replace the value with 1.25.0.
|
rebase DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Bumps [golang.org/x/term](https://github.com/golang/term) from 0.39.0 to 0.41.0. - [Commits](golang/term@v0.39.0...v0.41.0) --- updated-dependencies: - dependency-name: golang.org/x/term dependency-version: 0.41.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
2fb85e0 to
ea926fd
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Superseded by #1092. |
Bumps golang.org/x/term from 0.39.0 to 0.41.0.
Commits
9d2dc07go.mod: update golang.org/x dependenciesd954e03all: upgrade go directive to at least 1.25.0 [generated]3aff304go.mod: update golang.org/x dependencies