Skip to content

Build(deps): Bump golang.org/x/term from 0.39.0 to 0.41.0#1045

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/golang.org/x/term-0.41.0
Closed

Build(deps): Bump golang.org/x/term from 0.39.0 to 0.41.0#1045
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/golang.org/x/term-0.41.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Mar 16, 2026

Bumps golang.org/x/term from 0.39.0 to 0.41.0.

Commits
  • 9d2dc07 go.mod: update golang.org/x dependencies
  • d954e03 all: upgrade go directive to at least 1.25.0 [generated]
  • 3aff304 go.mod: update golang.org/x dependencies
  • See full diff in compare view

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Mar 16, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0b344c0b-0682-4abf-b8c1-f6669f897f19

📥 Commits

Reviewing files that changed from the base of the PR and between 2fb85e0 and ea926fd.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod
🚧 Files skipped from review as they are similar to previous changes (1)
  • go.mod

Walkthrough

Go toolchain requirement bumped from 1.24.13 to 1.25.0; direct dependency golang.org/x/term upgraded to v0.41.0; indirect dependency golang.org/x/sys upgraded to v0.42.0.

Changes

Cohort / File(s) Summary
Dependency and Toolchain Updates
go.mod
Updated Go toolchain to go 1.25.0. Bumped golang.org/x/term from v0.39.0 to v0.41.0. Bumped indirect golang.org/x/sys from v0.40.0 to v0.42.0. No API/signature changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change—bumping golang.org/x/term from 0.39.0 to 0.41.0, which is the primary modification in the changeset.
Description check ✅ Passed The description is directly related to the changeset, detailing the dependency bump and providing commit information from the upstream golang.org/x/term repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dependabot/go_modules/golang.org/x/term-0.41.0

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@go.mod`:
- Line 3: Update the GitHub Actions workflow jobs that set the go-version to
match go.mod's declared version: change the go-version keys in the
publish-release.yaml and check-pull-request.yaml workflows from older values
(1.22/1.23) to 1.25.0 so CI uses the same Go toolchain as go.mod; search each
workflow for the go-version: entries and replace the value with 1.25.0.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3b82ef9e-33eb-427c-bbeb-d214dcd0b9a1

📥 Commits

Reviewing files that changed from the base of the PR and between 188c8ce and 2fb85e0.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Comment thread go.mod
module github.com/openshift-online/ocm-cli

go 1.24.13
go 1.25.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Checking for Go version pins across common config files..."
rg -n --hidden -g '!go.sum' -g '!.git' -P '\b(go\s+1\.(24|25)(\.\d+)?)\b|go-version\s*:\s*["'\'']?1\.(24|25)(\.\d+)?|FROM\s+golang:1\.(24|25)(\.\d+)?|GO_VERSION\s*[:=]\s*["'\'']?1\.(24|25)(\.\d+)?' .

echo
echo "Checking GitHub Actions setup-go usage..."
rg -n --hidden -g '.github/workflows/*.yml' -g '.github/workflows/*.yaml' -P 'setup-go|go-version' .

Repository: openshift-online/ocm-cli

Length of output: 637


Update Go versions in GitHub Actions workflows to match go.mod 1.25.0.

The go module declares go 1.25.0 but CI workflows are pinned to older versions:

  • .github/workflows/publish-release.yaml (line 45): go-version: 1.23
  • .github/workflows/check-pull-request.yaml (lines 51, 77): go-version: 1.22 and 1.23

Update both workflows to use go-version: 1.25.0 to match the module's minimum version and ensure CI tests against the correct toolchain.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@go.mod` at line 3, Update the GitHub Actions workflow jobs that set the
go-version to match go.mod's declared version: change the go-version keys in the
publish-release.yaml and check-pull-request.yaml workflows from older values
(1.22/1.23) to 1.25.0 so CI uses the same Go toolchain as go.mod; search each
workflow for the go-version: entries and replace the value with 1.25.0.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 31, 2026

rebase

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Bumps [golang.org/x/term](https://github.com/golang/term) from 0.39.0 to 0.41.0.
- [Commits](golang/term@v0.39.0...v0.41.0)

---
updated-dependencies:
- dependency-name: golang.org/x/term
  dependency-version: 0.41.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/go_modules/golang.org/x/term-0.41.0 branch from 2fb85e0 to ea926fd Compare March 31, 2026 18:00
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign rcampos2029 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github Apr 13, 2026

Superseded by #1092.

@dependabot dependabot Bot closed this Apr 13, 2026
@dependabot dependabot Bot deleted the dependabot/go_modules/golang.org/x/term-0.41.0 branch April 13, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants