Build(deps): Bump cloud.google.com/go/iam from 1.5.3 to 1.7.0#1081
Build(deps): Bump cloud.google.com/go/iam from 1.5.3 to 1.7.0#1081dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [cloud.google.com/go/iam](https://github.com/googleapis/google-cloud-go) from 1.5.3 to 1.7.0. - [Release notes](https://github.com/googleapis/google-cloud-go/releases) - [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/documentai/CHANGES.md) - [Commits](googleapis/google-cloud-go@iam/v1.5.3...iap/v1.7.0) --- updated-dependencies: - dependency-name: cloud.google.com/go/iam dependency-version: 1.7.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughUpdated Go toolchain version from 1.24.13 to 1.25.0 in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
Bot
added
the
needs-ok-to-test
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
go.mod (1)
12-12: Prefererrors.Asfor resilient GCP error matching after upgradinggax-goandgoogle.golang.org/api.The codebase uses direct type assertions to
*googleapi.Errorand*apierror.APIErrorin multiple places (e.g.,cmd/ocm/gcp/gcp-client-shim.go,pkg/gcp/error_handlers.go). These can become brittle if errors are wrapped during the library upgrades. Useerrors.Asinstead, as already demonstrated in theisNotFoundfunction.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` at line 12, Several places use direct type assertions to *googleapi.Error and *apierror.APIError which breaks when errors are wrapped; update those checks to use errors.As like the existing isNotFound function does. For each occurrence (e.g., in cmd/ocm/gcp/gcp-client-shim.go and pkg/gcp/error_handlers.go) import the standard "errors" package and replace constructs like err.(*googleapi.Error) or err.(*apierror.APIError) with an errors.As-based pattern that declares a target variable of the appropriate type and calls errors.As(err, &target) before inspecting fields; ensure you handle both underlying types where previously asserted and preserve existing logic paths.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 3: go.mod declares Go 1.25.0 but CI workflows still pin older Go
versions; update every CI YAML's go-version entries to match or exceed "1.25" to
avoid build mismatches. Locate all occurrences of the YAML key go-version in
your workflow files (the entries currently set to 1.22 and 1.23) and change them
to 1.25 (or a newer compatible minor, e.g., 1.25.x), then re-run CI to verify
builds succeed against the go.mod requirement.
---
Nitpick comments:
In `@go.mod`:
- Line 12: Several places use direct type assertions to *googleapi.Error and
*apierror.APIError which breaks when errors are wrapped; update those checks to
use errors.As like the existing isNotFound function does. For each occurrence
(e.g., in cmd/ocm/gcp/gcp-client-shim.go and pkg/gcp/error_handlers.go) import
the standard "errors" package and replace constructs like err.(*googleapi.Error)
or err.(*apierror.APIError) with an errors.As-based pattern that declares a
target variable of the appropriate type and calls errors.As(err, &target) before
inspecting fields; ensure you handle both underlying types where previously
asserted and preserve existing logic paths.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c0a60cec-fdf4-4d4e-85ea-3152583d56dc
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| module github.com/openshift-online/ocm-cli | ||
|
|
||
| go 1.24.13 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Read-only check for Go version pins that may drift from go.mod
set -euo pipefail
echo "== go.mod =="
rg -n '^\s*go\s+[0-9]+\.[0-9]+(\.[0-9]+)?\s*$' go.mod
echo
echo "== Common CI / build pin locations =="
fd -HI '(^|/)(Dockerfile|Containerfile|Makefile|.*\.mk|.*\.yml|.*\.yaml)$' . \
| xargs -r rg -n 'golang:|GO_VERSION|setup-go|actions/setup-go|go-version|FROM\s+golang|^\s*go\s+[0-9]+\.[0-9]+(\.[0-9]+)?'Repository: openshift-online/ocm-cli
Length of output: 578
Update CI workflow Go versions to match go.mod 1.25.0.
CI workflows are pinned to Go 1.22 and 1.23, which are older than the minimum specified in go.mod (1.25.0). This mismatch will cause build inconsistencies:
.github/workflows/publish-release.yaml:45—go-version: 1.23.github/workflows/check-pull-request.yaml:51—go-version: 1.22.github/workflows/check-pull-request.yaml:77—go-version: 1.23
Update all workflow pinned versions to 1.25 or higher to match the module directive.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 3, go.mod declares Go 1.25.0 but CI workflows still pin older
Go versions; update every CI YAML's go-version entries to match or exceed "1.25"
to avoid build mismatches. Locate all occurrences of the YAML key go-version in
your workflow files (the entries currently set to 1.22 and 1.23) and change them
to 1.25 (or a newer compatible minor, e.g., 1.25.x), then re-run CI to verify
builds succeed against the go.mod requirement.
|
Superseded by #1091. |
dependabot
Bot
deleted the
dependabot/go_modules/cloud.google.com/go/iam-1.7.0
branch
Bumps cloud.google.com/go/iam from 1.5.3 to 1.7.0.
Release notes
Sourced from cloud.google.com/go/iam's releases.
Changelog
Sourced from cloud.google.com/go/iam's changelog.
... (truncated)
Commits
c2bf628chore: release main (#7506)91a1f78chore: update iam and longrunning (#7553)b219a38chore: go mod tidy (#7552)8775caechore: update copyright year for generated protos (#7542)9373073chore(spanner): dummy commit to test spanner kokoro builds (#7549)3868b6cchore(main): release pubsub 1.29.0 (#7312)ae38ff1feat(security/privateca): remove apiv1beta1 (#7539)a7fc1d5chore(talent): update copyright year in the generated protos (#7541)d4931e9chore(talent): update copyright year in the generated protos (#7540)0df63fcdocs(dialogflow/cx): clarified wording around quota usage (#7538)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)