Skip to content

Build(deps): Bump k8s.io/apimachinery from 0.34.3 to 0.35.4#1097

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/k8s.io/apimachinery-0.35.4
Open

Build(deps): Bump k8s.io/apimachinery from 0.34.3 to 0.35.4#1097
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/k8s.io/apimachinery-0.35.4

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Apr 20, 2026

Bumps k8s.io/apimachinery from 0.34.3 to 0.35.4.

Commits
  • 475c941 Merge pull request #138356 from dims/update-moby-spdystream-v0.5.1-1.35
  • 6c08bb5 Update github.com/moby/spdystream from v0.5.0 to v0.5.1
  • 45398ef Merge pull request #137927 from lalitc375/cherry-pick-137864
  • b414b94 Fix backport differences for 1.35 (remove WithOrigin and MarkAlpha)
  • f933a4d Add slice and map union member support with tests
  • 977ad5b Use IsZero instead of IsNil for union ratcheting check
  • a128230 Fix union validation ratcheting when oldObj is nil
  • 72d71ea Merge remote-tracking branch 'origin/master' into release-1.35
  • e2a2dbc Bump golang.org/x/crypto to v0.45.0
  • 2e9c228 Merge pull request #135131 from Dev1622/sig-storage/mock-expand-flake-fix
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.34.3 to 0.35.4.
- [Commits](kubernetes/apimachinery@v0.34.3...v0.35.4)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-version: 0.35.4
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Apr 20, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Summary by CodeRabbit

  • Chores
    • Updated Go runtime toolchain to version 1.25.0, enabling enhanced performance improvements, security updates, and better compatibility with modern systems
    • Upgraded Kubernetes API machinery library to v0.35.4 to leverage latest features and receive essential security enhancements
    • Streamlined overall dependency management configuration to ensure optimal system stability and long-term reliability

Walkthrough

Updated the Go toolchain version from go 1.24.13 to go 1.25.0 and upgraded the k8s.io/apimachinery dependency from v0.34.3 to v0.35.4. Removed the indirect github.com/gogo/protobuf dependency.

Changes

Cohort / File(s) Summary
Go Module Configuration
go.mod
Upgraded Go toolchain requirement to 1.25.0, bumped k8s.io/apimachinery to v0.35.4, and removed unused indirect dependency github.com/gogo/protobuf.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: a dependency version bump of k8s.io/apimachinery from 0.34.3 to 0.35.4, which matches the primary alteration in go.mod.
Description check ✅ Passed The description is directly related to the changeset, providing details about the k8s.io/apimachinery dependency upgrade including upstream commits and Dependabot information.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dependabot/go_modules/k8s.io/apimachinery-0.35.4

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign miguelhbrito for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 20, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 20, 2026

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
go.mod (1)

33-33: No breaking changes detected with k8s.io/apimachinery v0.35.4 upgrade.

The version bump from v0.34.3 to v0.35.4 is compatible. The removed functions (WithOrigin and MarkAlpha) are not used in the codebase, and sets.NewString() remains supported in v0.35.4.

Optional: The sets.NewString() function used in pkg/arguments/interactive.go:392 is deprecated in Kubernetes 1.35+. Consider migrating to the generic sets.Set[string] type for future compatibility.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@go.mod` at line 33, The review notes that sets.NewString() used at
pkg/arguments/interactive.go (around the code referencing sets.NewString) is
deprecated in newer k8s versions; update that call to use the generic
sets.Set[string] API instead by replacing creation and usages of
sets.NewString(...) with sets.New[string](...) or constructing a
sets.Set[string] and adjust any type signatures/variables (e.g., change
variables typed as sets.String to sets.Set[string]) so the code compiles against
k8s.io/apimachinery v0.35.4 while preserving existing behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@go.mod`:
- Line 33: The review notes that sets.NewString() used at
pkg/arguments/interactive.go (around the code referencing sets.NewString) is
deprecated in newer k8s versions; update that call to use the generic
sets.Set[string] API instead by replacing creation and usages of
sets.NewString(...) with sets.New[string](...) or constructing a
sets.Set[string] and adjust any type signatures/variables (e.g., change
variables typed as sets.String to sets.Set[string]) so the code compiles against
k8s.io/apimachinery v0.35.4 while preserving existing behavior.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 62690e38-4675-43db-9f3c-85177029e010

📥 Commits

Reviewing files that changed from the base of the PR and between f80645d and 312dbd1.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 13, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update go code needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants