Build(deps): Bump k8s.io/apimachinery from 0.34.3 to 0.35.4#1097
Build(deps): Bump k8s.io/apimachinery from 0.34.3 to 0.35.4#1097dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.34.3 to 0.35.4. - [Commits](kubernetes/apimachinery@v0.34.3...v0.35.4) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-version: 0.35.4 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Summary by CodeRabbit
WalkthroughUpdated the Go toolchain version from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
go.mod (1)
33-33: No breaking changes detected with k8s.io/apimachinery v0.35.4 upgrade.The version bump from v0.34.3 to v0.35.4 is compatible. The removed functions (
WithOriginandMarkAlpha) are not used in the codebase, andsets.NewString()remains supported in v0.35.4.Optional: The
sets.NewString()function used inpkg/arguments/interactive.go:392is deprecated in Kubernetes 1.35+. Consider migrating to the genericsets.Set[string]type for future compatibility.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` at line 33, The review notes that sets.NewString() used at pkg/arguments/interactive.go (around the code referencing sets.NewString) is deprecated in newer k8s versions; update that call to use the generic sets.Set[string] API instead by replacing creation and usages of sets.NewString(...) with sets.New[string](...) or constructing a sets.Set[string] and adjust any type signatures/variables (e.g., change variables typed as sets.String to sets.Set[string]) so the code compiles against k8s.io/apimachinery v0.35.4 while preserving existing behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@go.mod`:
- Line 33: The review notes that sets.NewString() used at
pkg/arguments/interactive.go (around the code referencing sets.NewString) is
deprecated in newer k8s versions; update that call to use the generic
sets.Set[string] API instead by replacing creation and usages of
sets.NewString(...) with sets.New[string](...) or constructing a
sets.Set[string] and adjust any type signatures/variables (e.g., change
variables typed as sets.String to sets.Set[string]) so the code compiles against
k8s.io/apimachinery v0.35.4 while preserving existing behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 62690e38-4675-43db-9f3c-85177029e010
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Bumps k8s.io/apimachinery from 0.34.3 to 0.35.4.
Commits
475c941Merge pull request #138356 from dims/update-moby-spdystream-v0.5.1-1.356c08bb5Update github.com/moby/spdystream from v0.5.0 to v0.5.145398efMerge pull request #137927 from lalitc375/cherry-pick-137864b414b94Fix backport differences for 1.35 (remove WithOrigin and MarkAlpha)f933a4dAdd slice and map union member support with tests977ad5bUse IsZero instead of IsNil for union ratcheting checka128230Fix union validation ratcheting when oldObj is nil72d71eaMerge remote-tracking branch 'origin/master' into release-1.35e2a2dbcBump golang.org/x/crypto to v0.45.02e9c228Merge pull request #135131 from Dev1622/sig-storage/mock-expand-flake-fixDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)