OCI hook improvements#108
Merged
Merged
Conversation
The hook script was using rc=$(crun update ...) which captures stdout, but crun does not print its exit code to stdout. This caused empty rc values leading to "integer expression expected" and "numeric argument required" errors in production. Use the $? exit code instead. Signed-off-by: Igor Bezukh <ibezukh@redhat.com>
relying on files could be fragile while the data passed to the hook via the stdin is consistent. the cgroup path however doesn't appar in the stdin data so for that we still have to parse config.json Signed-off-by: Igor Bezukh <ibezukh@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
/cc @Barakmor1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Bezukh ibezukh@redhat.com
We've found a parsing issue in the hook script - rc variable was capturing the stdout instead
of capturing the exit code. This caused subsequent if conditions to fail.
In addition to the fix the PID is now parsed from the data passed to the hook stdin. This
improvement allows reliability in the data source.