Skip to content

NO-JIRA: Promote stable Tech Preview e2e tests into the default e2e-operator suite#382

Open
bharath-b-rh wants to merge 1 commit intoopenshift:masterfrom
bharath-b-rh:promote-tp-e2e
Open

NO-JIRA: Promote stable Tech Preview e2e tests into the default e2e-operator suite#382
bharath-b-rh wants to merge 1 commit intoopenshift:masterfrom
bharath-b-rh:promote-tp-e2e

Conversation

@bharath-b-rh
Copy link
Contributor

@bharath-b-rh bharath-b-rh commented Mar 17, 2026

Summary

Moves recently added Tech Preview e2e coverage into the default e2e-operator suite so it runs on the main CI path, after several tech-preview runs showed stable behavior.

Rationale

Those scenarios lived under the tech-preview job only while they were new. They’ve now been exercised repeatedly without observed flakiness, so promoting them matches GA-level confidence and avoids splitting “real” coverage behind an optional job.

What changed

  • Ginkgo labels: Removed TechPreview from the affected specs; aligned categorization with Platform:None (and related label updates) across:
    • ACME DNS01, self-signed CA, Vault issuers
    • Istio CSR, observe, overrides e2e packages
  • Makefile: E2E_GINKGO_LABEL_FILTER — AWS branch extended so the filter matches {AWS,None} (runs the same promoted tests on AWS and platform None as intended).

Verification

  • /test e2e-operator (required for merge on default suite)
  • /test e2e-operator-tech-preview — optional sanity that tech-preview job still passes after label moves

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 17, 2026
@openshift-ci-robot
Copy link

@bharath-b-rh: This pull request explicitly references no jira issue.

Details

In response to this:

The PR is for promoting the e2e scenarios which were added recently from e2e-operator-techpreview suite to regular e2e-operator, now that we had multiple executions of the test cases and no flakiness was observed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 134248dd-5593-46e6-a5b9-576d38185165

📥 Commits

Reviewing files that changed from the base of the PR and between 8eb5d9e and 9baf260.

📒 Files selected for processing (7)
  • Makefile
  • test/e2e/issuer_acme_dns01_test.go
  • test/e2e/issuer_selfsigned_ca_test.go
  • test/e2e/issuer_vault_test.go
  • test/e2e/istio_csr_test.go
  • test/e2e/observe_test.go
  • test/e2e/overrides_test.go

Walkthrough

The PR updates test labeling across multiple e2e test files by removing TechPreview labels from certain tests and introducing Platform:None labels to additional test suites. The Makefile's E2E_GINKGO_LABEL_FILTER is updated to include Platform:None in the AWS platform condition, broadening test selection criteria.

Changes

Cohort / File(s) Summary
Makefile Test Filter Configuration
Makefile
Updated E2E_GINKGO_LABEL_FILTER to expand AWS platform condition from {AWS} to {AWS,None}, enabling test selection for both AWS and None platforms.
Test Label Metadata Updates
test/e2e/issuer_acme_dns01_test.go, test/e2e/issuer_selfsigned_ca_test.go, test/e2e/issuer_vault_test.go, test/e2e/istio_csr_test.go, test/e2e/observe_test.go, test/e2e/overrides_test.go
Removed TechPreview labels from individual tests and test suites; added or changed labels to Platform:None across multiple Describe blocks to align with updated test categorization strategy.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

Migrating from UI to YAML configuration.

Use the @coderabbitai configuration command in a PR comment to get a dump of all your UI settings in YAML format. You can then edit this YAML file and upload it to the root of your repository to configure CodeRabbit programmatically.

@openshift-ci openshift-ci bot requested review from TrilokGeer and lunarwhite March 17, 2026 10:49
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2026
@bharath-b-rh
Copy link
Contributor Author

/test e2e-operator-tech-preview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2026

@bharath-b-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bharath-b-rh bharath-b-rh changed the title NO-JIRA: Promotes e2e scenarios marked as TechPreview to regular suite NO-JIRA: Promote stable Tech Preview e2e tests into the default e2e-operator suite Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants