Skip to content

NO-JIRA: issue-336: Sets openshift.io/cluster-monitoring as label in namespace#387

Draft
bharath-b-rh wants to merge 1 commit intoopenshift:masterfrom
bharath-b-rh:issue-336
Draft

NO-JIRA: issue-336: Sets openshift.io/cluster-monitoring as label in namespace#387
bharath-b-rh wants to merge 1 commit intoopenshift:masterfrom
bharath-b-rh:issue-336

Conversation

@bharath-b-rh
Copy link
Contributor

Fixes #336

The PR is for updating the openshift.io/cluster-monitoring as a label instead of annotation in the cert-manager namespace.

…namespace

Signed-off-by: Bharath B <bhb@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2026
@openshift-ci-robot
Copy link

@bharath-b-rh: This pull request explicitly references no jira issue.

Details

In response to this:

Fixes #336

The PR is for updating the openshift.io/cluster-monitoring as a label instead of annotation in the cert-manager namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from TrilokGeer and mytreya-rh March 20, 2026 07:01
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e235afce-8b92-416e-94ec-754b61464c8f

📥 Commits

Reviewing files that changed from the base of the PR and between 8eb5d9e and c1f2c85.

📒 Files selected for processing (2)
  • bindata/cert-manager-deployment/cert-manager-namespace.yaml
  • pkg/operator/assets/bindata.go

Walkthrough

The changes move the openshift.io/cluster-monitoring: "true" configuration from the metadata annotations field to the metadata labels field in the cert-manager Namespace manifest across two files, aligning with OpenShift documentation requirements.

Changes

Cohort / File(s) Summary
Cert-Manager Namespace Manifest
bindata/cert-manager-deployment/cert-manager-namespace.yaml, pkg/operator/assets/bindata.go
Migrated openshift.io/cluster-monitoring: "true" from metadata.annotations to metadata.labels in the Namespace resource definition.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Assessment against linked issues

Objective Addressed Explanation
Move openshift.io/cluster-monitoring: "true" from annotations to labels [#336]
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)


Comment @coderabbitai help to get the list of available commands and usage tips.

@bharath-b-rh
Copy link
Contributor Author

/test e2e-operator

@bharath-b-rh bharath-b-rh marked this pull request as draft March 20, 2026 10:37
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2026

@bharath-b-rh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator-tech-preview c1f2c85 link false /test e2e-operator-tech-preview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openshift.io/cluster-monitoring incorrectly set as annotation instead of a label

2 participants