Skip to content

[release-4.16] OCPBUGS-77196: Fix incomplete vendor/#302

Open
adobes1 wants to merge 1 commit intoopenshift:release-4.16from
adobes1:4.16-fix-vendor
Open

[release-4.16] OCPBUGS-77196: Fix incomplete vendor/#302
adobes1 wants to merge 1 commit intoopenshift:release-4.16from
adobes1:4.16-fix-vendor

Conversation

@adobes1
Copy link

@adobes1 adobes1 commented Dec 2, 2025

Hermetic builds require that running go mod vendor produces no diff. Without this PR, ose-libvirt-machine-controllers can't be built hermetically.

The changes in this PR are the result of running go mod vendor and ensuring that the vendored file is commited and not ignored by .gitignore

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 2, 2025
@openshift-ci-robot
Copy link
Contributor

@adobes1: This pull request explicitly references no jira issue.

Details

In response to this:

Hermetic builds require that running go mod vendor produces no diff. Without this PR, ose-libvirt-machine-controllers can't be built hermetically.

The changes in this PR are the result of running go mod vendor and ensuring that the vendored file is commited and not ignored by .gitignore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cfergeau and enxebre December 2, 2025 09:52
@adobes1
Copy link
Author

adobes1 commented Dec 3, 2025

/retest

@adobes1 adobes1 changed the title [release-4.16] NO-ISSUE: Fix incomplete vendor/ [release-4.16] OCPBUGS-77196: Fix incomplete vendor/ Feb 24, 2026
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 24, 2026
@openshift-ci-robot
Copy link
Contributor

@adobes1: This pull request references Jira Issue OCPBUGS-77196, which is invalid:

  • expected dependent Jira Issue OCPBUGS-77195 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Hermetic builds require that running go mod vendor produces no diff. Without this PR, ose-libvirt-machine-controllers can't be built hermetically.

The changes in this PR are the result of running go mod vendor and ensuring that the vendored file is commited and not ignored by .gitignore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cfergeau
Copy link
Contributor

/lgtm
/approve

@cfergeau
Copy link
Contributor

This has some go.sum changes, it’s the only one among all the PRs which were opened, dunno if that’s expected.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2026
@adobes1
Copy link
Author

adobes1 commented Mar 11, 2026

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2026

@adobes1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/govet 860f9ca link true /test govet
ci/prow/unit 860f9ca link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@adobes1
Copy link
Author

adobes1 commented Mar 20, 2026

/override ci/prow/unit

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2026

@adobes1: adobes1 unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

/override ci/prow/unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sdodson
Copy link
Member

sdodson commented Mar 20, 2026

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 20, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bcc8c685-1fb9-4667-a9de-60f9cb331ef1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sdodson
Copy link
Member

sdodson commented Mar 20, 2026

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 20, 2026
@openshift-ci-robot
Copy link
Contributor

@sdodson: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants