Skip to content

Periodic sync of OKD samples#683

Open
aroyoredhat wants to merge 1 commit intoopenshift:mainfrom
aroyoredhat:periodic-okd-sync
Open

Periodic sync of OKD samples#683
aroyoredhat wants to merge 1 commit intoopenshift:mainfrom
aroyoredhat:periodic-okd-sync

Conversation

@aroyoredhat
Copy link
Copy Markdown
Contributor

@aroyoredhat aroyoredhat commented Mar 30, 2026

Syncing the latest samples from the library to OKD.

Created using https://github.com/aroyoredhat/trigger-test-samples-build

Summary by CodeRabbit

  • Chores
    • Updated Open Liberty container images to version 26.0.0.4, supporting Java 8, 11, 17, and 21 versions.
    • Updated Rails and PostgreSQL deployment container image configurations with explicit versioning.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1582cebf-e18f-4aad-ad24-ec7349bd4d8d

📥 Commits

Reviewing files that changed from the base of the PR and between 7cf53e6 and 48571eb.

📒 Files selected for processing (2)
  • assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json
  • assets/operator/okd-x86_64/rails/templates/rails-pgsql-persistent.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json

Walkthrough

Bumped Open Liberty ImageStream tags from 26.0.0.2 to 26.0.0.4 (tags, display-name annotations, and S2I image references). Set explicit container images in Rails/PostgreSQL deployment templates: Rails containers to ${NAME}:latest and PostgreSQL to postgresql:${POSTGRESQL_VERSION}.

Changes

Open Liberty ImageStream Configuration

Layer / File(s) Summary
Tag updates
assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json
Updated spec.tags[] name values from 26.0.0.2-<java>26.0.0.4-<java> for Java 8, 11, 17, 21.
Annotations
assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json
Updated annotations["openshift.io/display-name"] to Open Liberty 26.0.0.4 with Java <ver> for each tag.
Image references
assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json
Updated from.name S2I image references from icr.io/appcafe/open-liberty-s2i:26.0.0.2-<java>icr.io/appcafe/open-liberty-s2i:26.0.0.4-<java>.

Rails + PostgreSQL Deployment Templates

Layer / File(s) Summary
Deployment container spec
assets/operator/okd-x86_64/rails/templates/rails-pgsql-persistent.json
Set Rails main container image to ${NAME}:latest.
Init container spec
assets/operator/okd-x86_64/rails/templates/rails-pgsql-persistent.json
Set ruby-init-container image to ${NAME}:latest.
PostgreSQL container spec
assets/operator/okd-x86_64/rails/templates/rails-pgsql-persistent.json
Set PostgreSQL container image to postgresql:${POSTGRESQL_VERSION}.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Periodic sync of OKD samples' accurately reflects the main changes: updating Open Liberty image versions and Rails/PostgreSQL deployment templates as part of a periodic synchronization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains only JSON configuration files with no Ginkgo test code or patterns.
Test Structure And Quality ✅ Passed PR contains only JSON configuration updates; no Ginkgo test files present in repository or modified in PR, making check not applicable.
Microshift Test Compatibility ✅ Passed This pull request only modifies JSON configuration files for OpenShift samples, updating Open Liberty image versions and Rails template references. No new Ginkgo e2e test files are being added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This pull request does not add any new Ginkgo e2e tests. The changes consist entirely of updates to OpenShift sample configuration files: specifically, JSON-based ImageStream and deployment template files in the assets/ directory. The modifications only update container image versions and references (Open Liberty from 26.0.0.2 to 26.0.0.4, and Rails/PostgreSQL image placeholders). Since no test code is being added to the repository, the SNO test compatibility check is not applicable to this pull request.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only update Open Liberty ImageStream versions and Rails/PostgreSQL container image references without introducing any topology-aware scheduling constraints, affinity rules, node selectors, or scheduling logic.
Ote Binary Stdout Contract ✅ Passed PR modifies only JSON configuration files with no Go source code changes, making the OTE Binary Stdout Contract check not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies only JSON configuration files for OpenShift ImageStreams and deployment templates, not executable Ginkgo test code, making this check inapplicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Review rate limit: 8/10 reviews remaining, refill in 11 minutes and 56 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from fbm3307 and shannon March 30, 2026 01:17
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aroyoredhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json (1)

17-99: ⚠️ Potential issue | 🔴 Critical

The Docker images for Open Liberty 26.0.0.3 do not exist at the specified registry and must be available before merge.

All four referenced images (26.0.0.3-java8, java11, java17, java21) at icr.io/appcafe/open-liberty-s2i are inaccessible and will cause deployment failures. Either push these images to the registry or revert the version references to available images.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json` around
lines 17 - 99, The image stream entries named "26.0.0.3-java8",
"26.0.0.3-java11", "26.0.0.3-java17", and "26.0.0.3-java21" reference
non-existent images in the from.name fields (e.g.
"icr.io/appcafe/open-liberty-s2i:26.0.0.3-java8") and must be fixed; either push
the corresponding images to icr.io with those tags or update each from.name to a
confirmed available tag (or revert the name fields back to the
last-known-working tag) and ensure the display name annotations
(openshift.io/display-name) stay consistent, then verify by doing a docker pull
of each updated from.name.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json`:
- Around line 17-99: The image stream entries named "26.0.0.3-java8",
"26.0.0.3-java11", "26.0.0.3-java17", and "26.0.0.3-java21" reference
non-existent images in the from.name fields (e.g.
"icr.io/appcafe/open-liberty-s2i:26.0.0.3-java8") and must be fixed; either push
the corresponding images to icr.io with those tags or update each from.name to a
confirmed available tag (or revert the name fields back to the
last-known-working tag) and ensure the display name annotations
(openshift.io/display-name) stay consistent, then verify by doing a docker pull
of each updated from.name.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7a8aae5f-ff07-4d07-8575-f3ac59b443f6

📥 Commits

Reviewing files that changed from the base of the PR and between eeac6ba and aa6d064.

📒 Files selected for processing (1)
  • assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json

@aroyoredhat aroyoredhat force-pushed the periodic-okd-sync branch from 7cf53e6 to 48571eb Compare May 4, 2026 02:31
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 4, 2026

@aroyoredhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant