Skip to content

Periodic sync of supported OCP samples#695

Open
aroyoredhat wants to merge 1 commit intoopenshift:mainfrom
aroyoredhat:periodic-ocp-sync
Open

Periodic sync of supported OCP samples#695
aroyoredhat wants to merge 1 commit intoopenshift:mainfrom
aroyoredhat:periodic-ocp-sync

Conversation

@aroyoredhat
Copy link
Copy Markdown
Contributor

@aroyoredhat aroyoredhat commented May 4, 2026

Syncing the latest supported OCP samples from the library.

Created using https://github.com/aroyoredhat/trigger-test-samples-build

Summary by CodeRabbit

  • Bug Fixes
    • Fixed container image references in deployment templates across all platforms. Rails and PostgreSQL containers now correctly reference their respective images instead of using empty/placeholder values.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2096bbee-3d14-4860-ab6a-afdb501508d0

📥 Commits

Reviewing files that changed from the base of the PR and between 0bfb6b3 and e4a284d.

📒 Files selected for processing (4)
  • assets/operator/ocp-aarch64/rails/templates/rails-pgsql-persistent.json
  • assets/operator/ocp-ppc64le/rails/templates/rails-pgsql-persistent.json
  • assets/operator/ocp-s390x/rails/templates/rails-pgsql-persistent.json
  • assets/operator/ocp-x86_64/rails/templates/rails-pgsql-persistent.json

Walkthrough

Four OpenShift deployment template files (one per CPU architecture) are updated to replace empty/placeholder image values with proper template variable references: Rails containers use ${NAME}:latest and PostgreSQL uses postgresql:${POSTGRESQL_VERSION}.

Changes

Container Image Template Variables

Layer / File(s) Summary
Rails & PostgreSQL Image Configuration
assets/operator/ocp-aarch64/rails/templates/rails-pgsql-persistent.json, assets/operator/ocp-ppc64le/rails/templates/rails-pgsql-persistent.json, assets/operator/ocp-s390x/rails/templates/rails-pgsql-persistent.json, assets/operator/ocp-x86_64/rails/templates/rails-pgsql-persistent.json
Rails main container and init container image fields set to ${NAME}:latest; PostgreSQL container image field set to postgresql:${POSTGRESQL_VERSION}. Same changes applied uniformly across all four architecture-specific template variants.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Periodic sync of supported OCP samples' is vague and does not clearly describe the specific substantive changes made in the PR. Consider a more descriptive title such as 'Fix container image references in Rails-PostgreSQL templates for all OCP architectures' to better communicate the actual changes.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This pull request does not modify any Ginkgo test files. The PR exclusively updates JSON OpenShift template files, and no test files are being changed.
Test Structure And Quality ✅ Passed This pull request does not contain any Ginkgo test code. All test files use the standard Go testing package with testing.T patterns, not Ginkgo's Describe/It blocks.
Microshift Test Compatibility ✅ Passed This PR modifies only JSON template files for container image references; no new Ginkgo e2e tests are introduced.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only JSON deployment templates without adding/modifying Ginkgo test code, making SNO compatibility assessment inapplicable.
Topology-Aware Scheduling Compatibility ✅ Passed Pull request only updates container image fields in OpenShift templates from empty placeholders to concrete references, with no scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed PR modifies only JSON template files for OpenShift container deployments; no Go source code or process-level code is modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR contains only JSON template changes for container images, not new Ginkgo e2e tests.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Review rate limit: 9/10 reviews remaining, refill in 6 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from fbm3307 and shannon May 4, 2026 02:32
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aroyoredhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 4, 2026

@aroyoredhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant