Skip to content

OCPBUGS-78997: install/0000_00_cluster-version-operator_03_deployment: Disable 1.35 client-go WatchListClient #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wking wants to merge 4 commits into
base: main
Choose a base branch
from
Open

OCPBUGS-78997: install/0000_00_cluster-version-operator_03_deployment: Disable 1.35 client-go WatchListClient #1355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
615e530
install/0000_00_cluster-version-operator_03_deployment: Disable 1.35 …
wking Mar 20, 2026
00a67b6
install/0000_00_cluster-version-operator_03_deployment: Allow Informe…
wking Mar 21, 2026
059b82f
install/0000_00_cluster-version-operator_03_deployment: Allow InOrder…
wking Mar 21, 2026
da1be8c
pkg/payload/testdata/TestRenderManifest_expected_cvo_deployment: Upda…
wking Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions install/0000_00_cluster-version-operator_30_deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ spec:
fieldPath: spec.nodeName
- name: CLUSTER_PROFILE
value: '{{ .ClusterProfile }}'
- name: KUBE_FEATURE_WatchListClient
value: "false"
Copy link
Copy Markdown
Member Author

@wking wking Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To help with review, these two lines (and the same in the generated test fixture) are the only changes since the merged #1282 :

$ git log --oneline origin/main..origin/pr/1355
a2ed8ce62 (wking/tune-client-go, origin/pr/1355, tune-client-go) pkg/payload/testdata/TestRenderManifest_expected_cvo_deployment: Update fixture
81ae26c7c install/0000_00_cluster-version-operator_03_deployment: Allow InOrderInformersBatchProcess default
02778be85 install/0000_00_cluster-version-operator_03_deployment: Allow InformerResourceVersion default
181af3196 install/0000_00_cluster-version-operator_03_deployment: Disable 1.35 client-go features
$ git diff origin/pr/1282..origin/pr/1355
diff --git a/install/0000_00_cluster-version-operator_03_deployment.yaml b/install/0000_00_cluster-version-operator_03_deployment.yaml
index ff85c55f9..40259b1bc 100644
--- a/install/0000_00_cluster-version-operator_03_deployment.yaml
+++ b/install/0000_00_cluster-version-operator_03_deployment.yaml
@@ -76,6 +76,8 @@ spec:
               fieldPath: spec.nodeName
         - name: CLUSTER_PROFILE
           value: '{{ .ClusterProfile }}'
+        - name: KUBE_FEATURE_WatchListClient
+          value: "false"
       # this pod is hostNetwork and uses the internal LB DNS name when possible, which the kubelet also uses.
       # this dnsPolicy allows us to use the same dnsConfig as the kubelet, without access to read it ourselves.
       dnsPolicy: Default
diff --git a/pkg/payload/testdata/TestRenderManifest_expected_cvo_deployment.yaml b/pkg/payload/testdata/TestRenderManifest_expected_cvo_deployment.yaml
index b3f0c40d1..dd728bbf0 100644
--- a/pkg/payload/testdata/TestRenderManifest_expected_cvo_deployment.yaml
+++ b/pkg/payload/testdata/TestRenderManifest_expected_cvo_deployment.yaml
@@ -76,6 +76,8 @@ spec:
               fieldPath: spec.nodeName
         - name: CLUSTER_PROFILE
           value: 'some-profile'
+        - name: KUBE_FEATURE_WatchListClient
+          value: "false"
       # this pod is hostNetwork and uses the internal LB DNS name when possible, which the kubelet also uses.
       # this dnsPolicy allows us to use the same dnsConfig as the kubelet, without access to read it ourselves.
       dnsPolicy: Default

# this pod is hostNetwork and uses the internal LB DNS name when possible, which the kubelet also uses.
# this dnsPolicy allows us to use the same dnsConfig as the kubelet, without access to read it ourselves.
dnsPolicy: Default
Expand Down
2 changes: 2 additions & 0 deletions pkg/payload/testdata/TestRenderManifest_expected_cvo_deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ spec:
fieldPath: spec.nodeName
- name: CLUSTER_PROFILE
value: 'some-profile'
- name: KUBE_FEATURE_WatchListClient
value: "false"
# this pod is hostNetwork and uses the internal LB DNS name when possible, which the kubelet also uses.
# this dnsPolicy allows us to use the same dnsConfig as the kubelet, without access to read it ourselves.
dnsPolicy: Default
Expand Down