[release-4.20] METAL-1564: Use available images#157
[release-4.20] METAL-1564: Use available images#157openshift-cherrypick-robot wants to merge 6 commits intoopenshift:release-4.20from
Conversation
Take the base filename from the DEPLOY_ISO/DEPLOY_INITRD environment variables instead of hardcoding it. Assisted-By: Cursor
Using a . instead of an _ is the standard for e.g. CoreOS images on the mirror. ABI uses agent.x86_64.iso. Since x86_64 already has an underscore in it, it may parse ambiguously in other contexts. Allow both so as not to break any existing code in development. Assisted-By: Cursor
A regression from 583e13f meant that the DEPLOY_ISO and DEPLOY_INITRD files would not be found unless they happened to be in the directory specified as IMAGE_SHARED_DIR (by default /shared/html/images). This change means that these files will always be found if specified, and that the directory/directories that contain them will be searched for arch-specific images unless the search directory is explicitly overridden by IMAGE_SHARED_DIR. Assisted-By: Cursor
The input images here are nothing to do with ironic, so choose a less confusing name. Assisted-By: Cursor
If no architecture-specific images are provided, fall back to the host architecture image when the requested architecture is the host architecture. Assisted-By: Cursor
If we don't have images available for the requested architecture, return false from SupportsArchitecture(). This ensures that the correct error message is set in the controller, and avoids a segfault when we try to call ServeImage() with an invalid architecture. Assisted-By: Cursor
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: METAL-1564 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest-required |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
Bot
added
the
lifecycle/stale
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
5 participants
This is an automated cherry-pick of #147
/assign honza