Skip to content

Conversation

@bdematte
Copy link

There is a make vendor command which is wrapping the different steps to update go.mod and revendor deps.
This should be documented in the project README but as it's being created in a different PR, I didn't make it part of it.
Overall, steps I did here where :

  1. update hack/update-go-module-dependencies.sh script with the following :
RELEASE=release-4.XX
K8S_RELEASE=v.0.XX.YY
GO_VERSION=1.XX
(...)
  1. update pinned version for sigs.k8s.io/cluster-api, sigs.k8s.io/cluster-api-provider-aws and sigs.k8s.io/cluster-api-provider-azure
  2. exclude from the go mod edit loop package which are potentially not following the same branching/versioning
  3. delete go.sum
  4. make build-all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bdematte
Once this PR has been reviewed and has the lgtm label, please assign yjst2012 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2025

@bdematte: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bdematte bdematte changed the title Fixing 'make vendor' [WIP] - Fixing 'make vendor' Sep 11, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2025
@hawkowl
Copy link
Collaborator

hawkowl commented Oct 2, 2025

@bdematte I might have mentioned this on Slack, but the 4.18 and 4.19 script works differently -- you might want to check that out and see if that's better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants