OCPBUGS-75250: Use correct Project ID with GCP Shared VPC#10297
OCPBUGS-75250: Use correct Project ID with GCP Shared VPC#10297openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
jira/severity-moderate
|
@sadasu: This pull request references Jira Issue OCPBUGS-75250, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
requested review from
barbacbd,
jianli-wei and
patrickdillon
| } | ||
|
|
||
| apiIntIPAddress, err := getInternalLBAddress(ctx, in.InstallConfig.Config.GCP.ProjectID, in.InstallConfig.Config.GCP.Region, getAPIAddressName(in.InfraID), in.InstallConfig.Config.GCP.Endpoint) | ||
| apiIntIPAddress, err := getInternalLBAddress(ctx, networkProjectID, in.InstallConfig.Config.GCP.Region, getAPIAddressName(in.InfraID), in.InstallConfig.Config.GCP.Endpoint) |
There was a problem hiding this comment.
My bad, I told you the wrong fix. This is actually ok as the LB is in the service project. The issue is here where we are using the host project instead of the service project.
There was a problem hiding this comment.
No worries. We realized we needed a different fairly quickly and thanks for helping us get to the right fix.
Switched to getting GCP Load Balancer IP addresses from the service project "GCP.ProjectID" in all cases, even when Shared VPC (XPN) is configured. This fix provides the correct project to use for getting the Load Balancer IP address when UserProvisionedDNS is enabled, and the ignition files are updated with the Load Balancer IP.
sadasu
force-pushed
the
sadasu-OCPBUGS-75250
branch
from
8675665 to
47e3ad9
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
/jira cc-qa |
|
@sadasu: This pull request references Jira Issue OCPBUGS-75250, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
The e2e-gcp-custom-dns job is failing due to https://issues.redhat.com/browse/OCPBUGS-75200. |
|
/test e2e-gcp-xpn-custom-dns |
|
/lgtm |
|
@jianli-wei and @barbacbd I looked at ci/prow/e2e-gcp-custom-dns. The errors I see there are known and the associated bug is https://issues.redhat.com/browse/OCPBUGS-75200 The errors I see in ci/prow/e2e-gcp-xpn-custom-dns seem to be related to clean up of Route53 entries used for custom-dns setup? |
|
|
/test e2e-gcp-xpn-custom-dns |
|
/verified by jiwei |
|
@jianli-wei: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
verified
|
/retest-required |
|
@sadasu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test okd-scos-images |
openshift-merge-bot
bot
merged commit 9cade28
into
openshift:main
|
@sadasu: An error was encountered searching for bug OCPBUGS-75250 on the Jira server at https://issues.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
No response returned: Get "https://issues.redhat.com/rest/api/2/issue/OCPBUGS-75250": GET https://issues.redhat.com/rest/api/2/issue/OCPBUGS-75250 giving up after 5 attempt(s)
Please contact an administrator to resolve this issue, then request a bug refresh with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.21 |
|
@sadasu: new pull request created: #10423 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
Problem: When userProvisionedDNS is enabled on GCP, the Installer tries to get the Load balancer IP address from the correct project. This LB IP is then used to update the bootstrap ignition file. When Shared VPC (XPN) was configured, Installer was trying to get the LB IP addresses from the Network Project ID and failing to get the LB IPs.
Solution: This LB IP is a front end configuration that should be read from the service project that is available in projectID.