OCPBUGS-79074: [release 4.21] - Allow all instance types in the install config for GCP

[barbacbd]

** validation.go:
Correct the error message to provide all supported instance types when one is not found.

** machinepools.go
Update the map to include all instance types and the supported disk types. The unsupported disk types are in comments in the map. These are to be updated when/if openshift supports these disktypes in the future.

This is a manual backport of OCPBUGS-74390.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 861c3ed8-1bc9-4d2a-866b-620b6231ece7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@barbacbd: This pull request references Jira Issue OCPBUGS-74390, which is invalid:

• expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.22.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
• expected Jira Issue OCPBUGS-74390 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

** validation.go:
Correct the error message to provide all supported instance types when one is not found.

** machinepools.go
Update the map to include all instance types and the supported disk types. The unsupported disk types are in comments in the map. These are to be updated when/if openshift supports these disktypes in the future.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[barbacbd]

/jira cherrypick OCPBUGS-74390

[openshift-ci-robot]

@barbacbd: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

** validation.go:
Correct the error message to provide all supported instance types when one is not found.

** machinepools.go
Update the map to include all instance types and the supported disk types. The unsupported disk types are in comments in the map. These are to be updated when/if openshift supports these disktypes in the future.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[barbacbd]

/jira cherrypick OCPBUGS-74390

[barbacbd]

/jira cherrypick OCPBUGS-74390

[openshift-ci-robot]

@barbacbd: This pull request references Jira Issue OCPBUGS-79074, which is invalid:

• expected dependent Jira Issue OCPBUGS-74390 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

** validation.go:
Correct the error message to provide all supported instance types when one is not found.

** machinepools.go
Update the map to include all instance types and the supported disk types. The unsupported disk types are in comments in the map. These are to be updated when/if openshift supports these disktypes in the future.

This is a manual backport of OCPBUGS-74390.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[barbacbd]

/cc @tthvo

[barbacbd]

/retest-required

[sadasu]

/approve

[sadasu]

/jira refresh

[openshift-ci-robot]

@sadasu: This pull request references Jira Issue OCPBUGS-79074, which is invalid:

• expected dependent Jira Issue OCPBUGS-74390 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sadasu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sadasu]

/retest-required

[sadasu]

/label backport-risk-assessed

[openshift-ci]

@barbacbd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-custom-dns	1e33168	link	false	/test e2e-gcp-custom-dns

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jianli-wei]

/jira refresh

[openshift-ci-robot]

@jianli-wei: This pull request references Jira Issue OCPBUGS-79074, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.z) matches configured target version for branch (4.21.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-74390 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-74390 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
• bug has dependents

Requesting review from QA contact:
/cc @jianli-wei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[barbacbd]

/test shellcheck

[tthvo]

/lgtm