[release-4.22] MULTIARCH-6077: PowerVS: Fix supported system types retrieval#10521
[release-4.22] MULTIARCH-6077: PowerVS: Fix supported system types retrieval#10521taliandre49 wants to merge 3 commits intoopenshift:release-4.22from
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
status: reviewing failed test |
|
/test e2e-ibmcloud-ovn |
1 similar comment
|
/test e2e-ibmcloud-ovn |
|
/label backport-risk-assessed |
|
@taliandre49 You'll need a Jira bug just for the backport to 4.22. This bug should depend on MULTIARCH-5824 that already merged. |
|
/test e2e-ibmcloud-ovn |
|
Status: The failing test appears to be unrelated to the PowerVS dal14 zone updates in this PR. The test is failing due to ingress/networking timeouts during IBM Cloud VPC cluster initialization, not PowerVS configuration issues. Evidence:
The PowerVS-specific changes in this PR are isolated and should not affect IBM Cloud VPC networking. |
|
/retitle [release-4.22] OCPBUGS-84875: PowerVS: Fix supported system types retrieval |
|
@taliandre49: This pull request references Jira Issue OCPBUGS-84875, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira-refresh |
|
/retitle [release-4.22] MULTIARCH-6077: PowerVS: Fix supported system types retrieval |
|
@taliandre49: This pull request references MULTIARCH-6077 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@mjturek: This pull request references MULTIARCH-6077 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4488382 to
4b94bd1
Compare
|
/test govet |
|
/test e2e-ibmcloud-ovn |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mjturek The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign bobbyradford |
|
@mjturek: GitHub didn't allow me to assign the following users: bobbyradford. Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign hasueki |
|
@mjturek: GitHub didn't allow me to assign the following users: hasueki. Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign rvanderp3 |
|
/unassign |
I'm not familiar enough with the changes to confidently approve. @patrickdillon can someone on the installer team take a look? |
|
/test e2e-ibmcloud-ovn |
|
/test e2e-aws-ovn-public-ipv4-pool I just wanted to see the result of this job :D This PR is the first 4.22 backport I can find :D |
|
/test e2e-ibmcloud-ovn |
|
CI job |
|
@taliandre49: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@patrickdillon Could you please point us to the correct individual on the installer team to assign approval for the PR and move it forward. Thank you! |
Backport of #10268 to
release-22.This PR fixes supported system type retrieval for PowerVS regions by adding
dal14 region support and enabling the s1122 system type.
Included changes
The powervs-utils version used matches the original change merged to
mainand represents the minimal dependency update required for this fix.
Original PR: #10268
Jira: MULTIARCH-5824