OLS-3150: Add googleCloudVertex.modelProvider to LLMProvider CRD#14
OLS-3150: Add googleCloudVertex.modelProvider to LLMProvider CRD#14onmete wants to merge 2 commits into
Conversation
…LS-3150) Introduce GoogleCloudVertexRuntime (Claude, Gemini, OpenAI) so Vertex providers declare which SDK stack they use. Operator routing is a follow-up; this PR is API and CRD only. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@onmete: This pull request references OLS-3150 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Use vendor-oriented values Anthropic, Google, and OpenAI instead of Claude, Gemini, and OpenAI SDK names. Co-authored-by: Cursor <cursoragent@cursor.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
c673e68 to
172226f
Compare
|
@onmete: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
GoogleCloudVertexModelProviderenum (Anthropic,Google,OpenAI) to distinguish which model provider stack a VertexLLMProviderusesgoogleCloudVertex.modelProviderfield onLLMProvider(CRD validation enforces presence and enum values)modelProvider: AnthropicThis PR is API/CRD only and should merge first. Operator routing that maps
modelProviderto sandbox SDK env vars will land in OLS-3126 / PR #13, which consumes this field once the CRD is available.Fixes OLS-3150 (CRD half).
modelProvider values
modelProviderAnthropicLIGHTSPEED_AGENT_PROVIDER=claude)GoogleLIGHTSPEED_AGENT_PROVIDER=gemini)OpenAILIGHTSPEED_AGENT_PROVIDER=openai)Example
Test plan
make manifestsmake test