Skip to content

OLS-3150: Add googleCloudVertex.modelProvider to LLMProvider CRD#14

Open
onmete wants to merge 2 commits into
openshift:mainfrom
onmete:ols-3150-vertex-runtime
Open

OLS-3150: Add googleCloudVertex.modelProvider to LLMProvider CRD#14
onmete wants to merge 2 commits into
openshift:mainfrom
onmete:ols-3150-vertex-runtime

Conversation

@onmete
Copy link
Copy Markdown
Contributor

@onmete onmete commented May 21, 2026

Summary

  • Add GoogleCloudVertexModelProvider enum (Anthropic, Google, OpenAI) to distinguish which model provider stack a Vertex LLMProvider uses
  • Add required googleCloudVertex.modelProvider field on LLMProvider (CRD validation enforces presence and enum values)
  • Update example manifest and test fixtures to set modelProvider: Anthropic

This PR is API/CRD only and should merge first. Operator routing that maps modelProvider to sandbox SDK env vars will land in OLS-3126 / PR #13, which consumes this field once the CRD is available.

Fixes OLS-3150 (CRD half).

modelProvider values

modelProvider Vertex stack (operator mapping in PR #13)
Anthropic Claude SDK (LIGHTSPEED_AGENT_PROVIDER=claude)
Google Google GenAI (LIGHTSPEED_AGENT_PROVIDER=gemini)
OpenAI OpenAI-compatible API (LIGHTSPEED_AGENT_PROVIDER=openai)

Example

spec:
  type: GoogleCloudVertex
  googleCloudVertex:
    credentialsSecret:
      name: llm-credentials
    projectID: my-gcp-project
    region: us-central1
    modelProvider: Anthropic

Test plan

  • make manifests
  • make test

…LS-3150)

Introduce GoogleCloudVertexRuntime (Claude, Gemini, OpenAI) so Vertex providers
declare which SDK stack they use. Operator routing is a follow-up; this PR is
API and CRD only.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 21, 2026

@onmete: This pull request references OLS-3150 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Add GoogleCloudVertexRuntime enum (Claude, Gemini, OpenAI) to distinguish which SDK stack a Vertex LLMProvider uses
  • Add required googleCloudVertex.runtime field on LLMProvider (CRD validation enforces presence and enum values)
  • Update example manifest and test fixtures to set runtime: Claude

This is API/CRD only — no operator sandbox env patching. Operator routing is a separate follow-up after OLS-3126 / PR #13 lands.

Fixes OLS-3150 (CRD half).

Test plan

  • make manifests
  • make test

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from blublinsky and harche May 21, 2026 06:24
Use vendor-oriented values Anthropic, Google, and OpenAI instead of
Claude, Gemini, and OpenAI SDK names.

Co-authored-by: Cursor <cursoragent@cursor.com>
@onmete onmete changed the title OLS-3150: Add GoogleCloudVertex runtime to LLMProvider CRD OLS-3150: Add googleCloudVertex.modelProvider to LLMProvider CRD May 21, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raptorsun for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@onmete onmete force-pushed the ols-3150-vertex-runtime branch from c673e68 to 172226f Compare May 21, 2026 06:46
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 21, 2026

@onmete: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 172226f link true /test unit
ci/prow/generate 172226f link true /test generate

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants