Skip to content

OLS-3018 Add kill switch spec for AgenticOLSConfig CR#15

Open
thoraxe wants to merge 1 commit into
openshift:mainfrom
thoraxe:ols-3018-kill-switch-spec
Open

OLS-3018 Add kill switch spec for AgenticOLSConfig CR#15
thoraxe wants to merge 1 commit into
openshift:mainfrom
thoraxe:ols-3018-kill-switch-spec

Conversation

@thoraxe
Copy link
Copy Markdown

@thoraxe thoraxe commented May 21, 2026

Summary

  • Adds .ai/spec/what/system-config.md specifying the new AgenticOLSConfig cluster-scoped singleton with spec.suspended kill switch
  • Introduces EmergencyStopped terminal phase for proposals terminated by the kill switch
  • Specifies console banner and CLI oc agentic suspend/resume commands
  • Updates existing specs (crd-api, proposal-lifecycle, sandbox-execution, reconciler) to integrate the new condition type and phase

Details

This is a spec-only change — no code changes. The spec defines behavioral rules for:

  • AgenticOLSConfig CRD (cluster-scoped singleton, spec.suspended bool)
  • Emergency termination of in-flight proposals (sandbox pod cleanup, RBAC cleanup, EmergencyStopped condition)
  • Reconciler integration via early-return guard and AgenticOLSConfig watch
  • Console danger banner when system is suspended
  • CLI status reporting and suspend/resume commands

Test plan

  • Review spec consistency across all modified files
  • Verify EmergencyStopped is correctly added to DerivePhase precedence in proposal-lifecycle.md
  • Verify cross-references between system-config.md and other specs are correct

🤖 Generated with Claude Code

Adds .ai/spec/what/system-config.md specifying the new AgenticOLSConfig
cluster-scoped singleton with spec.suspended kill switch, EmergencyStopped
terminal phase, console banner, and CLI suspend/resume commands.

Updates existing specs (crd-api, proposal-lifecycle, sandbox-execution,
reconciler) to integrate the new condition type and phase.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot requested review from harche and xrajesh May 21, 2026 15:42
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrajesh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant