OLS-3060: Add GET /ready readiness endpoint#48
Conversation
Independent of liveness refactor (OLS-3059). GET /health stays in app.py; readiness lives in health.py with provider_env and provider_endpoint checks per health-probes.md. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@onmete: An error was encountered searching for bug OLS-3060 on the Jira server at https://redhat.atlassian.net. No known errors were detected, please see the full error message for details. Full error message.
No response returned: Get "https://redhat.atlassian.net/rest/api/2/issue/OLS-3060": GET https://redhat.atlassian.net/rest/api/2/issue/OLS-3060 giving up after 5 attempt(s)
Please contact an administrator to resolve this issue, then request a bug refresh with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@onmete: This pull request references OLS-3060 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Readiness must not assume claude when the operator omits provider config; returns 503 until the env var is set explicitly. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@onmete: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
GET /readyreadiness probe perhealth-probes.md(OLS-3058 spike)provider_env: credential env var present forLIGHTSPEED_AGENT_PROVIDER(claude/gemini/openai)provider_endpoint: unauthenticated HTTP GET (3s timeout); any HTTP response including 4xx counts as reachable{"status":"ok"}or 503 with per-checkchecksmapGET /healthunchanged inapp.py— independent of OLS-3059 / OLS-3059: Extract GET /health liveness endpoint #47Related
Test plan
make test(30 tests; R2 mocked — no live network)make lintMade with Cursor