Skip to content

chore: remove ripgrep from container image#52

Open
vimalk78 wants to merge 1 commit into
openshift:mainfrom
vimalk78:remove-ripgrep
Open

chore: remove ripgrep from container image#52
vimalk78 wants to merge 1 commit into
openshift:mainfrom
vimalk78:remove-ripgrep

Conversation

@vimalk78
Copy link
Copy Markdown
Contributor

@vimalk78 vimalk78 commented May 21, 2026

ripgrep is not from an approved Red Hat source and would fail EC checks.
We can add it back later, when ripgrep is available in ubi payload

Co-authored-by: Claude Sonnet 4.6 noreply@anthropic.com

Summary by CodeRabbit

  • Chores
    • Removed ripgrep binary installation from container runtime configuration, simplifying dependency management by eliminating artifact handling and fallback download mechanisms.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Warning

Rate limit exceeded

@vimalk78 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 53 minutes and 38 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: bc4cb573-8941-477a-ba44-98423f95c3a3

📥 Commits

Reviewing files that changed from the base of the PR and between 4d378de and 1594347.

⛔ Files ignored due to path filters (1)
  • artifacts.lock.yaml is excluded by !artifacts.lock.yaml
📒 Files selected for processing (1)
  • Containerfile
📝 Walkthrough

Walkthrough

The Containerfile's runtime stage no longer installs the ripgrep binary. The change removes the entire ripgrep installation block, including artifact copying, cachi2 extraction, and GitHub download fallback logic.

Changes

Ripgrep Runtime Installation Removal

Layer / File(s) Summary
Remove ripgrep binary installation from runtime stage
Containerfile
Deleted the ripgrep installation block that copied artifacts.lock.yaml, extracted ripgrep from /cachi2/output/deps/generic/, and fell back to downloading from GitHub when the generic deps directory was absent.

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: removing ripgrep from the container image, which aligns with the changeset that deleted the runtime-stage logic for ripgrep installation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from blublinsky and raptorsun May 21, 2026 13:37
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raptorsun for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

  ripgrep is not from an approved Red Hat source and would fail EC
  checks. The agent does not require it as a shipped dependency.

  Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Signed-off-by: Vimal Kumar <vimal78@gmail.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 21, 2026

@vimalk78: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint 1594347 link true /test lint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant