4.19: Enable TypeScript noImplicitAny option & fix types as necessary

package.json

@@ -50,8 +50,13 @@
   },
   "devDependencies": {
     "@cypress/grep": "6.0.0",
+    "@types/js-yaml": "4.0.9",
+    "@types/lodash": "4.17.24",
+    "@types/murmurhash-js": "1.0.7",
     "@types/node": "^22.19.17",
     "@types/react": "^17.0.91",
+    "@types/react-modal": "3.16.3",
+    "@types/react-redux": "7.1.34",
     "@typescript-eslint/eslint-plugin": "^8.58.1",
     "@typescript-eslint/parser": "^8.58.1",
     "cypress": "15.14.2",

src/components/AttachLogModal.tsx

@@ -5,6 +5,7 @@ import { useDispatch } from 'react-redux';
 import {
   consoleFetchText,
   K8sResourceKind,
+  Selector,
   useK8sWatchResource,
 } from '@openshift-console/dynamic-plugin-sdk';
 import {
@@ -257,9 +258,9 @@ const AttachLogModal: React.FC<AttachLogModalProps> = ({ isOpen, onClose, resour
     isCronJob ? { isList: true, kind: 'Job', namespace } : null,
   );
 
-  let selector;
+  let selector: Selector | undefined;
   if (kind === 'Job') {
-    selector = { 'job-name': name };
+    selector = { matchLabels: { 'job-name': name } };
   } else if (isCronJob) {
     const ownedJobNames = (jobs || [])
       .filter((job) =>
@@ -281,7 +282,7 @@ const AttachLogModal: React.FC<AttachLogModalProps> = ({ isOpen, onClose, resour
       selector = undefined;
     }
   } else if (kind === 'VirtualMachine' || kind === 'VirtualMachineInstance') {
-    selector = { 'vm.kubevirt.io/name': name };
+    selector = { matchLabels: { 'vm.kubevirt.io/name': name } };
   } else if (scaleTarget && scaleTargetLoaded && !scaleTargetError) {
     selector = scaleTarget.spec?.selector;
   } else {
@@ -297,7 +298,8 @@ const AttachLogModal: React.FC<AttachLogModalProps> = ({ isOpen, onClose, resour
   const changePod = (newPod: K8sResourceKind) => {
     if (newPod) {
       setPod(newPod);
-      const newContainers = newPod.spec?.containers?.map((c) => c.name).sort() ?? [];
+      const newContainers =
+        newPod.spec?.containers?.map((c: { name: string }) => c.name).sort() ?? [];
       setContainers(newContainers);
       setContainer(newContainers[0]);
     }

src/components/AttachmentModal.tsx

@@ -2,7 +2,7 @@ import * as React from 'react';
 import { useTranslation } from 'react-i18next';
 import { useDispatch, useSelector } from 'react-redux';
 import { BlueInfoCircleIcon } from '@openshift-console/dynamic-plugin-sdk';
-import { CodeEditor, Language } from '@patternfly/react-code-editor';
+import { CodeEditor, EditorDidMount, Language } from '@patternfly/react-code-editor';
 import {
   ActionGroup,
   Button,
@@ -49,10 +49,10 @@ type EditorProps = {
 const Editor: React.FC<EditorProps> = ({ onChange }) => {
   const attachment: Attachment = useSelector((s: State) => s.plugins?.ols?.get('openAttachment'));
 
-  const onEditorDidMount = (_editor, monaco) => {
+  const onEditorDidMount: EditorDidMount = (_editor, monaco) => {
     // Work around crash when CodeEditor attempts to call this nonexistent function
     // TODO: Figure out why this is happening
-    monaco.editor.onDidChangeMarkers = () => {};
+    (monaco.editor as { onDidChangeMarkers: () => void }).onDidChangeMarkers = () => {};
   };
 
   const [isDarkTheme] = useIsDarkTheme();

src/components/AttachmentsSizeAlert.tsx

@@ -4,6 +4,7 @@ import { useSelector } from 'react-redux';
 import { Alert } from '@patternfly/react-core';
 
 import { State } from '../redux-reducers';
+import { Attachment } from '../types';
 
 const MAX_CHARS = 1000000;
 
@@ -12,7 +13,9 @@ const AttachmentsSizeAlert: React.FC = () => {
 
   const attachments = useSelector((s: State) => s.plugins?.ols?.get('attachments'));
 
-  const totalChars = attachments.valueSeq().reduce((sum, a) => sum + a.value.length, 0);
+  const totalChars = attachments
+    .valueSeq()
+    .reduce((sum: number, a: Attachment) => sum + a.value.length, 0);
 
   if (totalChars <= MAX_CHARS) {
     return null;

src/components/Prompt.tsx

@@ -8,6 +8,10 @@ import {
   consoleFetch,
   consoleFetchJSON,
   K8sResourceKind,
+  PrometheusAlert,
+  PrometheusRule,
+  PrometheusRulesResponse,
+  Silence,
   useK8sWatchResource,
 } from '@openshift-console/dynamic-plugin-sdk';
 import { MessageBar } from '@patternfly/chatbot';
@@ -184,8 +188,8 @@ const Prompt: React.FC<PromptProps> = ({ scrollIntoView }) => {
       reader.onload = (event) => {
         try {
           const yaml = event.target?.result as string;
-          const content = loadYAML(yaml);
-          if (typeof content !== 'object') {
+          const content = loadYAML(yaml) as K8sResourceKind | null;
+          if (typeof content !== 'object' || content === null) {
             setError(t('Uploaded file is not valid YAML'));
             return;
           }
@@ -356,8 +360,8 @@ const Prompt: React.FC<PromptProps> = ({ scrollIntoView }) => {
         const labels = Object.fromEntries(new URLSearchParams(location.search));
         const alertsEndpoint = labels.cluster ? ALERTS_THANOS_ENDPOINT : ALERTS_ENDPOINT;
         consoleFetchJSON(alertsEndpoint, 'get', getRequestInitWithAuthHeader())
-          .then((response) => {
-            let alert;
+          .then((response: PrometheusRulesResponse) => {
+            let alert: PrometheusAlert | undefined;
             each(response?.data?.groups, (group) => {
               each(group.rules, (rule) => {
                 alert = rule.alerts?.find((a) => isMatch(labels, a.labels));
@@ -406,7 +410,7 @@ const Prompt: React.FC<PromptProps> = ({ scrollIntoView }) => {
       } else if (kind === 'Silence') {
         setLoading();
         consoleFetchJSON(`${SILENCE_ENDPOINT}/${name}`, 'get', getRequestInitWithAuthHeader())
-          .then((silence) => {
+          .then((silence: Silence) => {
             try {
               const silenceName =
                 silence.matchers
@@ -433,8 +437,8 @@ const Prompt: React.FC<PromptProps> = ({ scrollIntoView }) => {
         const ruleLabels = Object.fromEntries(new URLSearchParams(location.search));
         const rulesEndpoint = ruleLabels.cluster ? ALERTS_THANOS_ENDPOINT : ALERTS_ENDPOINT;
         consoleFetchJSON(rulesEndpoint, 'get', getRequestInitWithAuthHeader())
-          .then((response) => {
-            let matchedRule;
+          .then((response: PrometheusRulesResponse) => {
+            let matchedRule: PrometheusRule | undefined;
             each(response?.data?.groups, (group) => {
               const found = group.rules?.find(
                 (rule) => rule.type === 'alerting' && alertingRuleID(group, rule) === name,
@@ -575,7 +579,7 @@ const Prompt: React.FC<PromptProps> = ({ scrollIntoView }) => {
 
     dispatch(
       chatHistoryPush({
-        attachments: attachments.map((a) => omit(a, 'originalValue')),
+        attachments: attachments.map((a: Attachment) => omit(a, 'originalValue')),
         hidden: hidePrompt,
         text: query,
         who: 'user',
@@ -907,7 +911,7 @@ const Prompt: React.FC<PromptProps> = ({ scrollIntoView }) => {
         hasStopButton={isStreaming}
         innerRef={textareaRef}
         isSendButtonDisabled={!query || query.trim().length === 0}
-        onChange={(e) => onChange(e, e.target.value)}
+        onChange={(e: React.ChangeEvent<HTMLTextAreaElement>) => onChange(e, e.target.value)}
         onSendMessage={onSubmit}
         placeholder={
           isTroubleshooting

src/hooks/usePopover.ts

@@ -6,7 +6,7 @@ import Popover from '../components/Popover';
 
 const POPOVER_ID = 'plugin__lightspeed-console-plugin__POPOVER_ID';
 
-const usePopover = () => {
+const usePopover = (): null => {
   const [isLaunched, , setLaunched] = useBoolean(false);
 
   const launchModal = useModal();
@@ -18,7 +18,7 @@ const usePopover = () => {
     }
   }, [isLaunched, launchModal, setLaunched]);
 
-  return [];
+  return null;
 };
 
 export default usePopover;

src/redux-reducers.ts

@@ -77,14 +77,14 @@ const reducer = (state: OLSState, action: OLSAction): OLSState => {
     case ActionType.ChatHistoryUpdateByID: {
       const index = state
         .get('chatHistory')
-        .findIndex((entry) => entry.get('id') === action.payload.id);
+        .findIndex((entry: ImmutableMap<string, unknown>) => entry.get('id') === action.payload.id);
       return state.mergeIn(['chatHistory', index], action.payload.entry);
     }
 
     case ActionType.ChatHistoryUpdateTool: {
       const index = state
         .get('chatHistory')
-        .findIndex((entry) => entry.get('id') === action.payload.id);
+        .findIndex((entry: ImmutableMap<string, unknown>) => entry.get('id') === action.payload.id);
       return state.mergeIn(
         ['chatHistory', index, 'tools', action.payload.toolID],
         action.payload.tool,

src/validation.ts

@@ -14,7 +14,7 @@ export const alertingRuleID = (
     rule.query,
     ..._map(rule.labels, (v, k) => `${v}=${k}`),
   ].join(',');
-  return String(murmur3(key, 'monitoring-salt'));
+  return String(murmur3(key));
 };
 
 export const isValidAlertName = (value: string | null | undefined): boolean =>

tsconfig.json

@@ -7,7 +7,6 @@
     "jsx": "react",
     "allowJs": true,
     "strict": true,
-    "noImplicitAny": false,
     "strictNullChecks": false,
     "noUnusedLocals": true,
     "sourceMap": false,