OLS-1775 : Reconciling app-server and postgres on cert rotation. #1188
+321
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
sriroopar
force-pushed
the
cert-rotation-reconcilation
branch
4 times, most recently
from
f4c5972 to
43b5a83
Compare
sriroopar
force-pushed
the
cert-rotation-reconcilation
branch
from
71c1fb9 to
2f2cc67
Compare
Contributor
Author
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
sriroopar
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
sriroopar
force-pushed
the
cert-rotation-reconcilation
branch
from
2f2cc67 to
b7da0a9
Compare
Contributor
Author
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
sriroopar
force-pushed
the
cert-rotation-reconcilation
branch
3 times, most recently
from
83a1c5f to
323302d
Compare
openshift-merge-robot
added
the
needs-rebase
sriroopar
force-pushed
the
cert-rotation-reconcilation
branch
from
323302d to
e41b3a8
Compare
openshift-merge-robot
removed
the
needs-rebase
sriroopar
force-pushed
the
cert-rotation-reconcilation
branch
3 times, most recently
from
d72611e to
2757b93
Compare
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
raptorsun
reviewed
Jan 15, 2026
|
|
||
| // updateOLSDeployment updates the deployment based on CustomResource configuration. | ||
| func updateOLSDeployment(r reconciler.Reconciler, ctx context.Context, existingDeployment, desiredDeployment *appsv1.Deployment) error { | ||
| func updateOLSDeployment(r reconciler.Reconciler, ctx context.Context, cr *olsv1alpha1.OLSConfig, existingDeployment, desiredDeployment *appsv1.Deployment) error { |
Contributor
There was a problem hiding this comment.
the argument cr is not used in this function. shall we remove it?
raptorsun
reviewed
Jan 15, 2026
| } | ||
|
|
||
| err = updateOLSDeployment(r, ctx, existingDeployment, desiredDeployment) | ||
| err = updateOLSDeployment(r, ctx, cr, existingDeployment, desiredDeployment) |
Contributor
There was a problem hiding this comment.
cr is not used in the function updateOLSDeployment
sriroopar
force-pushed
the
cert-rotation-reconcilation
branch
from
2757b93 to
1889a16
Compare
sriroopar
force-pushed
the
cert-rotation-reconcilation
branch
from
1889a16 to
5b5e026
Compare
Contributor
Author
|
/retest |
|
@sriroopar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing