-
Notifications
You must be signed in to change notification settings - Fork 461
CORS-3849: Enable hosts plugin within the CoreDNS Corefile for cloud platforms #5569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@sadasu: This pull request references CORS-3849 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sadasu, zaneb The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test e2e-gcp-op-ocl |
Update the CoreDNS Corefile for cloud platforms to enable the hosts plugin. the hosts plugin was enabled within the cluster's Corefile specifically for Node addresses. This change enables all enrties within the /etc/hosts file to be loadede and served via the DNS service provided by the cluster's coreDNS instance.
484ae32 to
3b9e9db
Compare
|
New changes are detected. LGTM label has been removed. |
|
@sadasu: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Update the CoreDNS Corefile for cloud platforms to enable the hosts plugin. the hosts plugin was enabled within the cluster's Corefile specifically for Node addresses. This change enables all enrties within the /etc/hosts file to be loadede and served via the DNS service provided by the cluster's coreDNS instance.
Please note that the hosts plugin was already enabled in the CoreFile for the cluster CoreDNS instance (as opposed to the bootstrap CoreDNS instance). Only some entries were loaded. After this change, all entries from the /etc/hosts file would be loaded and served by CoreDNS.
This feature was requested by ARO but we feel that the hosts plugin should be enabled on all cloud platforms (GCP, AWS and Azure) at all times and not just when run within ARO.