Skip to content

Conversation

@sadasu
Copy link
Contributor

@sadasu sadasu commented Jan 19, 2026

Update the CoreDNS Corefile for cloud platforms to enable the hosts plugin. the hosts plugin was enabled within the cluster's Corefile specifically for Node addresses. This change enables all enrties within the /etc/hosts file to be loadede and served via the DNS service provided by the cluster's coreDNS instance.

Please note that the hosts plugin was already enabled in the CoreFile for the cluster CoreDNS instance (as opposed to the bootstrap CoreDNS instance). Only some entries were loaded. After this change, all entries from the /etc/hosts file would be loaded and served by CoreDNS.

This feature was requested by ARO but we feel that the hosts plugin should be enabled on all cloud platforms (GCP, AWS and Azure) at all times and not just when run within ARO.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 19, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2026

@sadasu: This pull request references CORS-3849 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Update the CoreDNS Corefile for cloud platforms to enable the hosts plugin. the hosts plugin was enabled within the cluster's Corefile specifically for Node addresses. This change enables all enrties within the /etc/hosts file to be loadede and served via the DNS service provided by the cluster's coreDNS instance.

Please note that the hosts plugin was already enabled in the CoreFile for the cluster CoreDNS instance (as opposed to the bootstrap CoreDNS instance). Only some entries were loaded. After this change, all entries from the /etc/hosts file would be loaded and served by CoreDNS.

This feature was requested by ARO but we feel that the hosts plugin should be enabled on all cloud platforms (GCP, AWS and Azure) at all times and not just when run within ARO.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zaneb
Copy link
Member

zaneb commented Jan 22, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sadasu, zaneb
Once this PR has been reviewed and has the lgtm label, please assign isabella-janssen for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadasu
Copy link
Contributor Author

sadasu commented Jan 22, 2026

/test e2e-gcp-op-ocl

Update the CoreDNS Corefile for cloud platforms to enable the hosts
plugin. the hosts plugin was enabled within the cluster's Corefile
specifically for Node addresses. This change enables all enrties
within the /etc/hosts file to be loadede and served via the DNS
service provided by the cluster's coreDNS instance.
@sadasu sadasu force-pushed the hosts-plugin-cloud-platforms branch from 484ae32 to 3b9e9db Compare January 22, 2026 01:00
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

@sadasu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-ocl 3b9e9db link true /test e2e-gcp-op-ocl

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants