[release-4.17] OCPBUGS-77242: After OCL is enabled few phases in MCN are not updating as expected by dkhater-redhat · Pull Request #5575 · openshift/machine-config-operator

dkhater-redhat · 2026-01-20T00:02:01Z

- What I did
Added missing MachineConfigNode condition updates to updateOnClusterBuild() for UpdatePrepared, UpdateCompatible, and UpdateFilesAndOS. These conditions were only being set in the regular update() path, causing them to remain False when OCL is enabled.
- How to verify it

Enable OCL on a cluster
Apply a MachineConfig change
Watch oc get machineconfignode -w -o wide
Verify the UPDATEPREPARED, UPDATECOMPATIBLE, and UPDATEDFILESANDOS columns transition from False to True/Unknown as expected, matching the behavior without OCL
- Description for the changelog

openshift-ci-robot · 2026-01-20T00:02:07Z

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-43435, which is invalid:

expected the bug to target the "4.17.z" version, but no target version was set
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-43435 to depend on a bug targeting a version in 4.18.0, 4.18.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did
Added missing MachineConfigNode condition updates to updateOnClusterBuild() for UpdatePrepared, UpdateCompatible, and UpdateFilesAndOS. These conditions were only being set in the regular update() path, causing them to remain False when OCL is enabled.
- How to verify it

Enable OCL on a cluster

Apply a MachineConfig change

Watch oc get machineconfignode -w -o wide

Verify the UPDATEPREPARED, UPDATECOMPATIBLE, and UPDATEDFILESANDOS columns transition from False to True/Unknown as expected, matching the behavior without OCL
- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dkhater-redhat · 2026-01-20T00:46:28Z

/test unit

dkhater-redhat · 2026-01-20T01:01:10Z

/test unit

isabella-janssen · 2026-01-23T18:49:32Z

/hold

Need confirmation on affected versions: https://issues.redhat.com/browse/OCPBUGS-43435?focusedId=28890040&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-28890040

dkhater-redhat · 2026-01-28T20:59:09Z

when ocl is being enable and the image is rolling out to the node, these are the MCN conditions

❯ oc get machineconfignode -o wide -w
NAME                                         UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATECOMPATIBLE   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   RELOADEDCRIO   UNCORDONEDNODE
ip-10-0-111-130.us-west-1.compute.internal   True      False            False            False                      False            True      False              False               False          False         False          False          False
ip-10-0-13-219.us-west-1.compute.internal    False     True             Unknown          False                      False            False     True               Unknown             True           True          False          False          False
ip-10-0-25-175.us-west-1.compute.internal    True      False            False            False                      False            True      False              False               False          False         False          False          False
ip-10-0-35-191.us-west-1.compute.internal    True      False            False            False                      False            True      False              False               False          False         False          False          False
ip-10-0-9-211.us-west-1.compute.internal     True      False            False            False                      False            True      False              False               False          False         False          False          False
ip-10-0-93-34.us-west-1.compute.internal     True      False            False            False                      False            True      False              False               False          False         False          False          False
ip-10-0-13-219.us-west-1.compute.internal    False     True             Unknown          True                       False            False     True               Unknown             True           True          True           False          False
ip-10-0-13-219.us-west-1.compute.internal    False     True             Unknown          True                       False            False     True               Unknown             True           True          True           False          False
ip-10-0-13-219.us-west-1.compute.internal    False     True             Unknown          True                       False            False     True               Unknown             True           True          True           False          False
ip-10-0-13-219.us-west-1.compute.internal    False     True             Unknown          True                       False            False     True               Unknown             True           True          True           False          False
ip-10-0-13-219.us-west-1.compute.internal    False     True             Unknown          True                       False            True      True               Unknown             True           True          True           False          False
ip-10-0-13-219.us-west-1.compute.internal    False     True             Unknown          True                       True             True      True               Unknown             True           True          True           False          True
ip-10-0-13-219.us-west-1.compute.internal    False     True             Unknown          True                       True             True      True               Unknown             True           True          True           False          True
ip-10-0-13-219.us-west-1.compute.internal    True      False            False            False                      False            False     False              False               False          False         False          False          False

openshift-ci-robot · 2026-01-28T21:51:55Z

@dkhater-redhat: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

- What I did
Added missing MachineConfigNode condition updates to updateOnClusterBuild() for UpdatePrepared, UpdateCompatible, and UpdateFilesAndOS. These conditions were only being set in the regular update() path, causing them to remain False when OCL is enabled.
- How to verify it

Enable OCL on a cluster

Apply a MachineConfig change

Watch oc get machineconfignode -w -o wide

Verify the UPDATEPREPARED, UPDATECOMPATIBLE, and UPDATEDFILESANDOS columns transition from False to True/Unknown as expected, matching the behavior without OCL
- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dkhater-redhat · 2026-02-05T17:11:47Z

/retest-required

isabella-janssen

/lgtm
/label backport-risk-assessed

openshift-ci-robot · 2026-02-24T18:33:16Z

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-77242, which is invalid:

expected dependent Jira Issue OCPBUGS-74644 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did
Added missing MachineConfigNode condition updates to updateOnClusterBuild() for UpdatePrepared, UpdateCompatible, and UpdateFilesAndOS. These conditions were only being set in the regular update() path, causing them to remain False when OCL is enabled.
- How to verify it

Enable OCL on a cluster

Apply a MachineConfig change

Watch oc get machineconfignode -w -o wide

Verify the UPDATEPREPARED, UPDATECOMPATIBLE, and UPDATEDFILESANDOS columns transition from False to True/Unknown as expected, matching the behavior without OCL
- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dkhater-redhat · 2026-02-24T22:31:59Z

/retest-required

dkhater-redhat · 2026-02-26T19:14:33Z

/verified by QE

openshift-ci-robot · 2026-02-26T19:14:45Z

@dkhater-redhat: This PR has been marked as verified by QE.

Details

In response to this:

/verified by QE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dkhater-redhat · 2026-02-26T19:14:53Z

/unhold

dkhater-redhat · 2026-02-27T05:00:36Z

/jira refresh

openshift-ci-robot · 2026-02-27T05:00:45Z

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-77242, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.17.z) matches configured target version for branch (4.17.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-74644 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-74644 targets the "4.18.z" version, which is one of the valid target versions: 4.18.0, 4.18.z
bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen

/lgtm
/label backport-risk-assessed

Clean backport

openshift-ci · 2026-02-27T14:37:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat, isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dkhater-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dkhater-redhat · 2026-02-28T05:45:37Z

/retest-required

openshift-ci · 2026-02-28T08:12:38Z

@dkhater-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-02-28T08:15:43Z

@dkhater-redhat: Jira Issue Verification Checks: Jira Issue OCPBUGS-77242
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-77242 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

- What I did
Added missing MachineConfigNode condition updates to updateOnClusterBuild() for UpdatePrepared, UpdateCompatible, and UpdateFilesAndOS. These conditions were only being set in the regular update() path, causing them to remain False when OCL is enabled.
- How to verify it

Enable OCL on a cluster

Apply a MachineConfig change

Watch oc get machineconfignode -w -o wide

Verify the UPDATEPREPARED, UPDATECOMPATIBLE, and UPDATEDFILESANDOS columns transition from False to True/Unknown as expected, matching the behavior without OCL
- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-03-01T02:31:07Z

Fix included in accepted release 4.17.0-0.nightly-2026-02-28-191526

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2026

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 20, 2026

openshift-ci Bot requested review from djoshy and yuqi-zhang January 20, 2026 00:02

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2026

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2026

dkhater-redhat force-pushed the fix-mcn-conditions-ocl-4.17 branch 2 times, most recently from ff6003c to a51ceed Compare January 28, 2026 21:36

dkhater-redhat changed the title ~~[release-4.17] OCPBUGS-43435: After OCL is enabled few phases in MCN are not updating as expected~~ [release-4.17] After OCL is enabled few phases in MCN are not updating as expected Jan 28, 2026

openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 28, 2026

isabella-janssen reviewed Feb 10, 2026

View reviewed changes

Comment thread pkg/daemon/update.go Outdated

dkhater-redhat force-pushed the fix-mcn-conditions-ocl-4.17 branch from a51ceed to 5ca4fb1 Compare February 10, 2026 18:54

dkhater-redhat force-pushed the fix-mcn-conditions-ocl-4.17 branch from 5ca4fb1 to 21061d7 Compare February 24, 2026 18:06

isabella-janssen reviewed Feb 24, 2026

View reviewed changes

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 24, 2026

openshift-ci Bot assigned anuragthehatter, imatza-rh, lyman9966, mhanss, ptalgulk01, rbbratta and rioliu-rh Feb 24, 2026

openshift-ci Bot assigned sergiordlr, zhaozhanqi and isabella-janssen Feb 24, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2026

added mcn conditions to ocl sync

4edc4f0

dkhater-redhat force-pushed the fix-mcn-conditions-ocl-4.17 branch from 21061d7 to 4edc4f0 Compare February 24, 2026 18:12

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2026

dkhater-redhat changed the title ~~[release-4.17] After OCL is enabled few phases in MCN are not updating as expected~~ [release-4.17] OCPBUGS-77242: After OCL is enabled few phases in MCN are not updating as expected Feb 24, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 24, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 26, 2026

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 27, 2026

openshift-ci Bot requested a review from sergiordlr February 27, 2026 05:00

isabella-janssen reviewed Feb 27, 2026

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2026

openshift-merge-bot Bot merged commit 039f983 into openshift:release-4.17 Feb 28, 2026
11 checks passed

Conversation

dkhater-redhat commented Jan 20, 2026

Uh oh!

openshift-ci-robot commented Jan 20, 2026

Uh oh!

dkhater-redhat commented Jan 20, 2026

Uh oh!

dkhater-redhat commented Jan 20, 2026

Uh oh!

isabella-janssen commented Jan 23, 2026

Uh oh!

dkhater-redhat commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 28, 2026

Uh oh!

dkhater-redhat commented Feb 5, 2026

Uh oh!

Uh oh!

isabella-janssen left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Feb 24, 2026

Uh oh!

dkhater-redhat commented Feb 24, 2026

Uh oh!

dkhater-redhat commented Feb 26, 2026

Uh oh!

openshift-ci-robot commented Feb 26, 2026

Uh oh!

dkhater-redhat commented Feb 26, 2026

Uh oh!

dkhater-redhat commented Feb 27, 2026

Uh oh!

openshift-ci-robot commented Feb 27, 2026

Uh oh!

isabella-janssen left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Feb 27, 2026

Uh oh!

dkhater-redhat commented Feb 28, 2026

Uh oh!

openshift-ci Bot commented Feb 28, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 28, 2026

Uh oh!

openshift-merge-robot commented Mar 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

dkhater-redhat commented Jan 28, 2026 •

edited

Loading