OCPBUGS-85497: only check password hash in /etc/shadow

[cheesesashimi]

- What I did

In #5889, some changes were introduced to how password changes are done. This had the side-effect of breaking the TestNoReboot E2E test. The root cause of the test failure is that the E2E test was considering the entire line in /etc/shadow when it should only consider whether the password hash changed.

The reason why is because the 3rd column changed during the password change to reflect the day of the password change. Technically speaking, if one were to change their password multiple times in a single day, this value would only change oncee. By comparison, the E2E test should only consider whether the password hash was changed without giving consideration to when it was changed.

This PR remedies this situation.

- How to verify it

Run the /test e2e-gcp-op-part1 on this PR and ensure that TestNoReboot passes.

- Description for the changelog
TestNoReboot should only consider the password hash

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@cheesesashimi: This pull request references Jira Issue OCPBUGS-85497, which is invalid:

• expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.23" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did

In #5889, some changes were introduced to how password changes are done. This had the side-effect of breaking the TestNoReboot E2E test. The root cause of the test failure is that the E2E test was considering the entire line in /etc/shadow when it should only consider whether the password hash changed.

The reason why is because the 3rd column changed during the password change to reflect the day of the password change. Technically speaking, if one were to change their password multiple times in a single day, this value would only change oncee. By comparison, the E2E test should only consider whether the password hash was changed without giving consideration to when it was changed.

This PR remedies this situation.

- How to verify it

Run the /test e2e-gcp-op-part1 on this PR and ensure that TestNoReboot passes.

- Description for the changelog
TestNoReboot should only consider the password hash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Warning

Rate limit exceeded

@cheesesashimi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 36 minutes and 16 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 92c6744f-3cb5-4785-b415-61d1aecb2c7c

📥 Commits

Reviewing files that changed from the base of the PR and between 99cb8a4 and 749f4e3.

📒 Files selected for processing (1)

• test/e2e-1of2/mcd_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cheesesashimi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cheesesashimi]

/test e2e-gcp-op-part1

[openshift-ci]

@cheesesashimi: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.