OCPBUGS-70285: Upgrade cypress to v15 to fix CVEs#345
OCPBUGS-70285: Upgrade cypress to v15 to fix CVEs#345upalatucci wants to merge 1 commit intoopenshift:mainfrom
Conversation
…ess to v15 to fix CVE-2025-15284 Upgrade cypress from v12 to v15, along with @cypress/webpack-preprocessor (v5 -> v7) and cypress-multi-reporters (v1 -> v2), to resolve the qs DoS vulnerability (CVE-2025-15284) in the transitive dependency @cypress/request. This also resolves the related @cypress/request SSRF (GHSA-p8p7-x288-28g6) and form-data (GHSA-fjxv-7rqg-78g4) vulnerabilities that were present in cypress v12. CVE fixes addressed: - CVE-2025-13465 (lodash): already at 4.17.23 - CVE-2026-22029 (react-router): not affected (v5, not v7) - CVE-2025-15284 (qs): fixed by cypress upgrade - CVE-2025-12816 (node-forge): not in dependency tree - CVE-2025-66031 (node-forge): not in dependency tree Co-authored-by: Cursor <cursoragent@cursor.com>
|
@upalatucci: This pull request references Jira Issue OCPBUGS-70282, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-70283, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-70284, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-70285, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughUpdated three development dependencies in package.json: Cyrus Cypress preprocessor to v7.0.0, Cypress to v15.0.0, and Cypress multi-reporter to v2.0.0. No scripts or other dependencies were modified. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@upalatucci: This pull request references Jira Issue OCPBUGS-70282, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-70283, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-70284, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-70285, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
35-59:⚠️ Potential issue | 🟡 MinorUpdate
@types/nodeto^20for consistency with Cypress 15's Node.js requirement.Cypress 15 requires Node.js 20.x, 22.x, or 24.x and dropped support for Node 18. While the OCP 4.22 builder image (
rhel-9-base-nodejs-openshift-4.22) likely already provides Node 20+, the devDependency@types/nodeat line 48 is still set to^18.0.0. Update it to^20.0.0to align the type definitions with your actual runtime and testing environment.No
enginesfield exists in package.json, so explicitly set"engines": { "node": ">=20" }to prevent developers from using Node 18.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@upalatucci: This pull request references Jira Issue OCPBUGS-70285, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-74473, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-73660, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-67252, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-66283, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@upalatucci: This pull request references Jira Issue OCPBUGS-70285, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-74473, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-73660, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-67252, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-66283, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@upalatucci: This pull request references Jira Issue OCPBUGS-70285, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.21 |
|
@upalatucci: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/jira refresh |
|
@upalatucci: This pull request references Jira Issue OCPBUGS-70285, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@upalatucci: This pull request references Jira Issue OCPBUGS-70285, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@upalatucci: This pull request references Jira Issue OCPBUGS-70285, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@upalatucci: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Upgrade dependencies to resolve open CVEs.
Dependency Updates
cypress:^12.17.4→^15.0.0@cypress/webpack-preprocessor:^5.15.5→^7.0.0cypress-multi-reporters:^1.6.2→^2.0.0Jira Issues