Skip to content

[release-4.21] CNV-59877: Fix permissions request for NADs#353

Open
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.21from
openshift-cherrypick-robot:cherry-pick-352-to-release-4.21
Open

[release-4.21] CNV-59877: Fix permissions request for NADs#353
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.21from
openshift-cherrypick-robot:cherry-pick-352-to-release-4.21

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #352

/assign upalatucci

Add namespace to the useAccessReview hook so it checks namespace-scoped
RBAC instead of cluster-level access. Pass the permission result to
NADListEmpty so the create button is hidden when the user lacks
permission to create NetworkAttachmentDefinitions.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 25, 2026

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: CNV-59877

Details

In response to this:

This is an automated cherry-pick of #352

/assign upalatucci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@upalatucci
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0e83989 and 2 for PR HEAD 6b14d2f in total

@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2026

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 6b14d2f link true /test e2e
ci/prow/images 6b14d2f link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants