Skip to content

Conversation

@weshayutin
Copy link
Contributor

@weshayutin weshayutin commented Feb 10, 2026

fixes

fixes issue: 2083

Why the changes were made

  • need to check we're using opm appropriately
  • works on arm

How to test the changes made

$(OPM) validate catalog/
	$(OPM) generate dockerfile catalog/ --binary-image=quay.io/operator-framework/opm:$(OPM_VERSION)
	$(CONTAINER_TOOL) build --load $(DOCKER_BUILD_ARGS) -f catalog.Dockerfile -t $(CATALOG_IMG) .
	rm -rf catalog.Dockerfile catalog/

The key fix is that the docker build command now uses $(DOCKER_BUILD_ARGS) which includes --platform=linux/arm64 for this ARM64 cluster, ensuring the catalog image contains the correct architecture opm binary.

make deploy-olm on arm64 cluster.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

Walkthrough

Makefile changes update the catalog-build target to use file-based catalog (FBC) generation instead of opm index add semver, explicitly push catalog images via docker-push in the catalog-push target, and enhance deploy-olm timeout diagnostics with CatalogSource and pod logs.

Changes

Cohort / File(s) Summary
Catalog Build & Push
Makefile
catalog-build target refactored to generate file-based catalog by rendering bundles to index.yaml, appending metadata, validating, generating dockerfile, and building image; catalog-push target updated to explicitly push via docker-push.
Deployment Diagnostics
Makefile
deploy-olm timeout wait logic enhanced to print CatalogSource YAML, catalog pod status, and pod logs before exit on timeout failure.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2026

@weshayutin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.22-e2e-test-aws ccbbd51 link false /test 4.22-e2e-test-aws
ci/prow/4.21-e2e-test-aws ccbbd51 link true /test 4.21-e2e-test-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants