Skip to content

CNV-71192: Add TP support for custom video device selection when crea…#104234

Merged
MirzWeiss merged 1 commit intoopenshift:mainfrom
MirzWeiss:CNV-71192
Jan 22, 2026
Merged

CNV-71192: Add TP support for custom video device selection when crea…#104234
MirzWeiss merged 1 commit intoopenshift:mainfrom
MirzWeiss:CNV-71192

Conversation

@MirzWeiss
Copy link
Copy Markdown
Contributor

@MirzWeiss MirzWeiss commented Dec 21, 2025 •
edited
Loading

Version(s):
Main, 4.21

Issue: CNV-71192

Link to docs preview:

QE review:

  • QE has approved this change.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 21, 2025 •
edited by openshift-ci Bot
Loading

@MirzWeiss: This pull request references CNV-71192 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Version(s):
Main, 4.21

Issue: CNV-71192

Link to docs preview

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 21, 2025
@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 21, 2025
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Dec 21, 2025 •
edited
Loading

🤖 Mon Jan 12 07:44:50 - Prow CI generated the docs preview:

https://104234--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/creating_vms_advanced/creating_vms_cli/virt-creating-vms-from-cli.html
https://104234--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/virt/creating_vms_advanced/creating_vms_cli/virt-creating-vms-from-cli.html
https://104234--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/creating_vms_advanced/creating_vms_cli/virt-creating-vms-from-cli.html

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Dec 21, 2025
View reviewed changes
Comment thread modules/virt-creating-vm-cli.adoc
Copy link
Copy Markdown
Collaborator

@ocpdocs-vale-bot ocpdocs-vale-bot Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDocDITA.ShortDescription: Assign [role="_abstract"] to a paragraph to use it as in DITA.

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Dec 21, 2025
View reviewed changes
Comment thread modules/virt-supported-custom-video-devices.adoc Outdated
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Dec 21, 2025
View reviewed changes
Comment thread modules/virt-supported-custom-video-devices.adoc
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Dec 21, 2025
View reviewed changes
Comment thread virt/creating_vms_advanced/creating_vms_cli/virt-creating-vms-from-cli.adoc
Copy link
Copy Markdown
Collaborator

@ocpdocs-vale-bot ocpdocs-vale-bot Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDocDITA.ShortDescription: Assign [role="_abstract"] to a paragraph to use it as in DITA.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 22, 2025 •
edited by openshift-ci Bot
Loading

@MirzWeiss: This pull request references CNV-71192 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Version(s):
Main, 4.21

Issue: CNV-71192

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dasionov
dasionov reviewed Dec 22, 2025
View reviewed changes
Comment thread modules/virt-creating-vm-cli.adoc Outdated
@MirzWeiss MirzWeiss force-pushed the CNV-71192 branch 2 times, most recently from 8d0452e to c67b134 Compare December 23, 2025 08:13
@MirzWeiss MirzWeiss added this to the Planned for 4.21 GA milestone Dec 23, 2025
@MirzWeiss MirzWeiss added CNV Label for all CNV PRs branch/enterprise-4.21 labels Dec 23, 2025
dasionov
dasionov approved these changes Dec 23, 2025
View reviewed changes
Copy link
Copy Markdown

@dasionov dasionov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MirzWeiss Thank you for this PR!

akri3i
akri3i suggested changes Dec 24, 2025
View reviewed changes
Comment thread modules/virt-supported-custom-video-devices.adoc Outdated
Comment thread modules/virt-supported-custom-video-devices.adoc Outdated
@MirzWeiss MirzWeiss force-pushed the CNV-71192 branch 2 times, most recently from 2997675 to cfd3acd Compare December 24, 2025 09:50
@akri3i
Copy link
Copy Markdown

akri3i commented Dec 24, 2025

/lgtm

@MirzWeiss MirzWeiss requested a review from akri3i December 24, 2025 09:52
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 24, 2025 •
edited by openshift-ci Bot
Loading

@MirzWeiss: This pull request references CNV-71192 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Version(s):
Main, 4.21

Issue: CNV-71192

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 24, 2025

@akri3i: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

erpeters157
erpeters157 reviewed Jan 6, 2026
View reviewed changes
Comment thread modules/virt-supported-custom-video-devices.adoc Outdated
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 12, 2026

@MirzWeiss: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@MirzWeiss MirzWeiss merged commit d4088d6 into openshift:main Jan 22, 2026
2 checks passed
@MirzWeiss
Copy link
Copy Markdown
Contributor Author

MirzWeiss commented Jan 22, 2026

/cherrypick enterprise-4.21

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jan 22, 2026

@MirzWeiss: new pull request created: #105187

Details

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akri3i akri3i Awaiting requested review from akri3i

3 more reviewers

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@erpeters157 erpeters157 erpeters157 left review comments

@dasionov dasionov dasionov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.21 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.21 GA

Development

Successfully merging this pull request may close these issues.

8 participants

@MirzWeiss @openshift-ci-robot @ocpdocs-previewbot @akri3i @openshift-cherrypick-robot @ocpdocs-vale-bot @erpeters157 @dasionov