Skip to content

[WIP] CNTRLPLANE-3052: remove unnecessary exceptions from monitoring test #30924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ehearne-redhat wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −44
Open

[WIP] CNTRLPLANE-3052: remove unnecessary exceptions from monitoring test #30924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 3 additions & 44 deletions pkg/monitortests/authentication/nodefaultserviceaccountoperatortests/monitortest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,55 +42,14 @@ func exceptionWithJira(prefix, jiraURL string) func(corev1.Pod) (string, bool) {

// OpenShift components should not be using the default service account.
// Therefore, no new components should be added to this list.
Copy link
Contributor Author

@ehearne-redhat ehearne-redhat Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also add a comment here e.g. // The following are current exceptions due to not being part of the core OpenShift payload, or we are waiting on components to reach GA.

Copy link
Contributor Author

@ehearne-redhat ehearne-redhat Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can simplify this to // The following are current exceptions due to not being part of the core OpenShift payload

// The following are current exceptions due to not being part of the core OpenShift
// payload, or we are waiting on components to reach GA.
var exceptions = []func(pod corev1.Pod) (string, bool){
exceptionWithJira("openshift-cluster-version/cluster-version-operator-", "https://issues.redhat.com/browse/OCPBUGS-65621"),
exceptionWithJira("openshift-console/downloads-", "https://issues.redhat.com/browse/OCPBUGS-65622"),
exceptionWithJira("openshift-etcd/etcd-guard-", "https://issues.redhat.com/browse/OCPBUGS-65626"),
exceptionWithJira("openshift-ingress-canary/ingress-canary-", "https://issues.redhat.com/browse/OCPBUGS-65629"),
exceptionWithJira("openshift-kube-apiserver/kube-apiserver-guard-", "https://issues.redhat.com/browse/OCPBUGS-65626"),
exceptionWithJira("openshift-kube-controller-manager/kube-controller-manager-guard-", "https://issues.redhat.com/browse/OCPBUGS-65626"),
exceptionWithJira("openshift-kube-scheduler/openshift-kube-scheduler-guard-", "https://issues.redhat.com/browse/OCPBUGS-65626"),
exceptionWithJira("openshift-monitoring/monitoring-plugin-", "https://issues.redhat.com/browse/OCPBUGS-65630"),
exceptionWithJira("openshift-multus/multus-", "https://issues.redhat.com/browse/OCPBUGS-65631"),
exceptionWithJira("openshift-network-console/networking-console-plugin-", "https://issues.redhat.com/browse/OCPBUGS-65633"),
exceptionWithJira("openshift-network-diagnostics/network-check-target-", "https://issues.redhat.com/browse/OCPBUGS-65633"),
exceptionWithJira("default/verify-all-openshiftcommunityoperators-", "https://issues.redhat.com/browse/OCPBUGS-65634"),
exceptionWithJira("default/verify-all-openshiftredhatmarketplace-", "https://issues.redhat.com/browse/OCPBUGS-65634"),
exceptionWithJira("default/verify-all-openshiftcertifiedoperators-", "https://issues.redhat.com/browse/OCPBUGS-65634"),
exceptionWithJira("default/verify-all-openshiftredhatoperators-", "https://issues.redhat.com/browse/OCPBUGS-65634"),
exceptionWithJira("openshift-cluster-version/version-", "https://issues.redhat.com/browse/OCPBUGS-65621"),
exceptionWithJira("kube-system/konnectivity-agent-", "https://issues.redhat.com/browse/OCPBUGS-65636"),
exceptionWithJira("openshift-multus/multus-additional-cni-plugins-", "https://issues.redhat.com/browse/OCPBUGS-65631"),
exceptionWithJira("openshift-multus/cni-sysctl-allowlist-ds-", "https://issues.redhat.com/browse/OCPBUGS-65631"),
exceptionWithJira("default/verify-metas-openshiftcertifiedoperators-", "https://issues.redhat.com/browse/OCPBUGS-65634"),
exceptionWithJira("default/verify-metas-openshiftcommunityoperators-", "https://issues.redhat.com/browse/OCPBUGS-65634"),
exceptionWithJira("default/verify-metas-openshiftredhatmarketplace-", "https://issues.redhat.com/browse/OCPBUGS-65634"),
exceptionWithJira("default/verify-metas-openshiftredhatoperators-", "https://issues.redhat.com/browse/OCPBUGS-65634"),
exceptionWithJira("openshift-cluster-api/capv-controller-manager-", "https://issues.redhat.com/browse/OCPBUGS-65637"), // keep until CAPV goes GA.
Copy link
Contributor Author

@ehearne-redhat ehearne-redhat Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can now also remove this one as it is implemented.

https://github.com/openshift/cluster-api-provider-vsphere/blob/master/openshift/capi-operator-manifests/default/manifests.yaml#L421-L524


// Handle the one outlier (Namespace only check) manually
func(pod corev1.Pod) (string, bool) {
if pod.Namespace == "openshift-marketplace" {
return "https://issues.redhat.com/browse/OCPBUGS-65867", true
}
return "", false
},

// These exceptions were found after the monitor test was merged.
exceptionWithJira("openshift-cnv/kubevirt-apiserver-proxy-", "https://issues.redhat.com/browse/OCPBUGS-70353"),
exceptionWithJira("openshift-cnv/kubevirt-console-plugin-", "https://issues.redhat.com/browse/OCPBUGS-70353"),
exceptionWithJira("kube-system/global-pull-secret-syncer-", "https://issues.redhat.com/browse/OCPBUGS-70354"),
exceptionWithJira("openshift-nmstate/nmstate-console-plugin-", "https://issues.redhat.com/browse/OCPBUGS-77474"),

// Handle the outlier (Namespace only check) manually
func(pod corev1.Pod) (string, bool) {
if pod.Namespace == "openshift-cluster-csi-drivers" {
return "https://issues.redhat.com/browse/OCPBUGS-70355", true
}
return "", false
},
// Handle the outlier manually
// This one checks if it is a debug pod or not.
Copy link
Contributor Author

@ehearne-redhat ehearne-redhat Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking we should probably add a comment here to explain why we are keeping it e.g. // debug pod does not run by default on an OpenShift cluster .

Copy link
Contributor Author

@ehearne-redhat ehearne-redhat Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this will be the only item here, we should probably provide stronger justification in the comments e.g. debug pod has showed up in some e2e tests. In order to stop these tests from failing we include it here.

// debug pod does not run by default on an OpenShift cluster
func(pod corev1.Pod) (string, bool) {
for annotation := range pod.Annotations {
if strings.Contains(annotation, "debug.openshift.io") {
Expand Down