NE-2501: Allow prometheus test pods to access Ingress Operator metrics port#30928
Conversation
New network policies will limit access to the Ingress Operator's metrics port to only pods within the openshift-monitoring namespace. Rather than creating test pods in the openshift-monitoring namespace, add a network policy that allows access to the metrics port from the test namespace.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
@rfredette: This pull request references NE-2501 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe change adds a new Prometheus network policy target to the authentication test in the Prometheus test suite. Specifically, Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.3)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Scheduling required tests: |
|
@simonpasquier please take a look at this; same network policy issue as #30753, but for the ingress operator. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfredette, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by @simonpasquier |
|
@simonpasquier: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rfredette: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
New network policies in openshift/cluster-ingress-operator#1392 will limit access to the Ingress Operator's metrics port to only pods within the openshift-monitoring namespace. Similar to #30753, allow the metrics test pods to access the Ingress Operator's metrics port with an additional network policy.