OTA-1813: Allow for alerts to fire from an e2e test

[hongkailiu]

Sometimes, alerts are triggers to test a feature [1]. We allow for them to fire in CI with a specific prefix on the alert name to avoid overlapping with any alert from production.

[1]. https://redhat.atlassian.net/browse/OTA-1813

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9c82c30c-ea45-45cc-8935-499df78a08cb

📥 Commits

Reviewing files that changed from the base of the PR and between 7f51565 and 83ae6e2.

📒 Files selected for processing (1)

• pkg/monitortests/testframework/legacytestframeworkmonitortests/alerts.go

🚧 Files skipped from review as they are similar to previous changes (1)

• pkg/monitortests/testframework/legacytestframeworkmonitortests/alerts.go

---

Walkthrough

isSkippedAlert now returns true for alert names prefixed with TestAlertFeatureE2ETest, causing those alerts to be excluded from backstop pending/firing checks and the "no new alerts firing" evaluation.

Changes

Cohort / File(s)	Summary
Alert Skipping Logic pkg/monitortests/testframework/legacytestframeworkmonitortests/alerts.go	isSkippedAlert updated to treat alert names starting with TestAlertFeatureE2ETest as skipped (returns true), in addition to existing allowed alert names.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.3)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@hongkailiu: This pull request references OTA-1812 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Sometimes, alerts are triggers to test a feature [1]. We allow for them to fire in CI with a specific prefix on the alert name to avoid overlapping with any alert from production.

[1]. https://redhat.atlassian.net/browse/OTA-1812

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@hongkailiu: This pull request references OTA-1813 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Sometimes, alerts are triggers to test a feature [1]. We allow for them to fire in CI with a specific prefix on the alert name to avoid overlapping with any alert from production.

[1]. https://redhat.atlassian.net/browse/OTA-1812

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@hongkailiu: This pull request references OTA-1813 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Sometimes, alerts are triggers to test a feature [1]. We allow for them to fire in CI with a specific prefix on the alert name to avoid overlapping with any alert from production.

[1]. https://redhat.atlassian.net/browse/OTA-1813

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[wking]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hongkailiu, wking
Once this PR has been reviewed and has the lgtm label, please assign petr-muller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment