Skip to content

NO-JIRA: Reverting case OOM score adjustment#30932

Open
kasturinarra wants to merge 1 commit intoopenshift:mainfrom
kasturinarra:remove_case_86080
Open

NO-JIRA: Reverting case OOM score adjustment#30932
kasturinarra wants to merge 1 commit intoopenshift:mainfrom
kasturinarra:remove_case_86080

Conversation

@kasturinarra
Copy link
Contributor

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 25296479-df67-4129-b8e7-d2290f1e2e15

📥 Commits

Reviewing files that changed from the base of the PR and between 394edfe and 1dae497.

📒 Files selected for processing (1)
  • test/extended/two_node/tnf_topology.go
💤 Files with no reviewable changes (1)
  • test/extended/two_node/tnf_topology.go

Walkthrough

Removed a Ginkgo test case from the two-node topology tests that verified etcd OOM score adjustment behavior across control-plane nodes. The deletion includes the associated constants, command parsing logic, and per-node assertions for the expected -997 OOM score value. Remaining tests continue to validate node infrastructure and etcd container status.

Changes

Cohort / File(s) Summary
Test case removal
test/extended/two_node/tnf_topology.go
Deleted Ginkgo test case verifying etcd OOM score adjustment, including constants for oom_score_adj checks, pcs resource describe command parsing, and expected value assertions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@fonta-rh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2026
@fonta-rh
Copy link
Contributor

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery-techpreview-3of3

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2026

@fonta-rh: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery-techpreview-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/46d0c2e0-282a-11f1-8155-9b6b8f8cb654-0

@kasturinarra kasturinarra changed the title Reverting case OOM score adjustment NO-JIRA: Reverting case OOM score adjustment Mar 25, 2026
@openshift-ci-robot
Copy link

@kasturinarra: This pull request explicitly references no jira issue.

Details

In response to this:

Reverting case based on the discussion here https://redhat-internal.slack.com/archives/C07ABRBBDK3/p1774378156314529?thread_ts=1774375299.856139&cid=C07ABRBBDK3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 25, 2026
@fonta-rh
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fonta-rh, kasturinarra
Once this PR has been reviewed and has the lgtm label, please assign eggfoobar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaypoulz
Copy link
Contributor

@kasturinarra I don't think we a full revert :) Just drop the [OCPFeatureGate:DualReplica] for now. You will need to move it out of the parent block though, so may it actually is just easier to revert. Up to you! :D

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2026

@kasturinarra: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-2of2 1dae497 link true /test e2e-aws-ovn-serial-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kasturinarra
Copy link
Contributor Author

@kasturinarra I don't think we a full revert :) Just drop the [OCPFeatureGate:DualReplica] for now. You will need to move it out of the parent block though, so may it actually is just easier to revert. Up to you! :D

I think i better revert and wait for the promotion to check my changes in and may be i feel that is better ?

@kasturinarra
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants