-
Notifications
You must be signed in to change notification settings - Fork 128
SDCICD-1715: updated osde2e README, created CONTRIBUTING.md and consolidated documents #3097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@minlei98: This pull request references SDCICD-1715 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: minlei98 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| - ROSA sanity (stage): `rosa,stage,sanity` | ||
| - ROSA full e2e (prod): `rosa,prod,e2e-suite` | ||
| - Region: e.g., `me-central-1` | ||
| - Instance Type: e.g., `x1e.xlarge` (or leave empty for random) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty will not select random machine type. default is m5.xlarge for rosa , In general it will be ocp default.
| - GCP sanity (stage): `gcp,stage,sanity` | ||
| - GCP full e2e (prod): `gcp,prod,e2e-suite` | ||
| - Region: e.g., `southamerica-west1` | ||
| - Instance Type: e.g., `custom-8-32768` (or leave empty for random) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above: leave empty for default
docs/Running-Tests.md
Outdated
| ```bash | ||
| ./out/osde2e test \ | ||
| --cluster-id ${CLUSTER_ID} \ | ||
| --environment stage \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line can be removed
docs/Running-Tests.md
Outdated
| export SKIP_DESTROY_CLUSTER=true # Don't delete cluster after tests | ||
| ``` | ||
|
|
||
| 4. **Run tests:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what type of tests is this for? we have multiple types: ad-hoc-images, standalone tests in test/ and some inbuilt tests in sanity suite, all with different methods
docs/Running-Tests.md
Outdated
| # Run tests | ||
| ./out/osde2e test \ | ||
| --cluster-id ${CLUSTER_ID} \ | ||
| --environment prod \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line can be removed
docs/Running-Tests.md
Outdated
| ```bash | ||
| ./out/osde2e test \ | ||
| --cluster-id ${CLUSTER_ID} \ | ||
| --environment stage \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line can be removed
docs/Running-Tests.md
Outdated
| ./out/osde2e test \ | ||
| --cluster-id ${CLUSTER_ID} \ | ||
| --environment stage \ | ||
| --configs stage \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to provide rosa/gcp and e2e-suite
docs/Running-Tests.md
Outdated
| Run tests based on Ginkgo labels: | ||
|
|
||
| ```bash | ||
| # Run all Operator tests except Upgrade tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Operator tests are ad-hoc-images, they won't be using label filters
docs/Running-Tests.md
Outdated
| --configs stage \ | ||
| --label-filter "Operators && !Upgrade" | ||
|
|
||
| # Run only E2E labeled tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this command will do anything
docs/Running-Tests.md
Outdated
| ### Skip Specific Tests | ||
|
|
||
| ```bash | ||
| ./out/osde2e test \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above , I don't think this command will do anything
docs/Running-Tests.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains a lot of incorrect commands and configs. Could you verify accuracy of all of them?
|
If this PR is generated by mainly AI, please add a note to the description ! |
|
@minlei98: This pull request references SDCICD-1715 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
|
@minlei98: This pull request references SDCICD-1715 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@minlei98: This pull request references SDCICD-1715 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@minlei98: This pull request references SDCICD-1715 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Major documentation restructure and updates:
New Documentation
(sanitizer, analysisengine, reporter) into comprehensive guide
Updated Authentication
Enhanced Documentation
Documentation Organization
Both AI and human are the contributors for this PR.