Skip to content

Conversation

@YiqinZhang
Copy link
Contributor

@YiqinZhang YiqinZhang commented Jan 30, 2026

Link S3 artifact URLs to Pod termination message for downstream consumption (qontract-reconcile, Tekton Results, etc.).

Changes:

  • Output structured JSON to stdout with ###OSDE2E_ARTIFACTS_JSON### markers
  • Write to /dev/termination-log (standard Kubernetes pattern)
  • Use SetEscapeHTML(false) to keep presigned URLs valid
  • S3 uploads only relevant test artifacts: .xml, .log, .yaml, .yml, .json, .png, .jpg, .jpeg, .gif, .csv, .txt, .html

Usage
From Pod status
kubectl get pod <pod> -o jsonpath='{.status.containerStatuses[0].state.terminated.message}'

From logs
kubectl logs <pod> | grep -A1 "###OSDE2E_ARTIFACTS_JSON###"

Output
{
"s3Uri": "s3://osde2e-loki-logs/test-results/...",
"junitUrl": "https://...?X-Amz-Algorithm=...&X-Amz-Credential=...",
"logsUrl": "https://...?X-Amz-Algorithm=...&X-Amz-Credential=..."
}

SDCICD-1737

@openshift-ci openshift-ci bot requested review from minlei98 and ritmun January 30, 2026 06:08
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YiqinZhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2026
@YiqinZhang YiqinZhang force-pushed the sdcicd-1737-s3-artifacts-url branch from 2cbaedd to 4a92d98 Compare January 30, 2026 06:15
@YiqinZhang
Copy link
Contributor Author

/test ci/prow/hypershift-pr-check

@YiqinZhang
Copy link
Contributor Author

/test hypershift-pr-check

1 similar comment
@YiqinZhang
Copy link
Contributor Author

/test hypershift-pr-check

@YiqinZhang YiqinZhang force-pushed the sdcicd-1737-s3-artifacts-url branch from 4a92d98 to 81d8fa6 Compare January 30, 2026 19:56
@YiqinZhang
Copy link
Contributor Author

/test hypershift-pr-check

@YiqinZhang YiqinZhang force-pushed the sdcicd-1737-s3-artifacts-url branch from 81d8fa6 to 30626f3 Compare January 30, 2026 21:37
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2026

@YiqinZhang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hypershift-pr-check 81d8fa6 link true /test hypershift-pr-check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant