Skip to content

Update module github.com/dustin/go-humanize to v1.0.1#2851

Open
red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/github.com-dustin-go-humanize-1.x
Open

Update module github.com/dustin/go-humanize to v1.0.1#2851
red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/github.com-dustin-go-humanize-1.x

Conversation

@red-hat-konflux
Copy link
Copy Markdown

@red-hat-konflux red-hat-konflux Bot commented Apr 6, 2025

This PR contains the following updates:

Package Change Age Confidence
github.com/dustin/go-humanize v1.0.0v1.0.1 age confidence

Warning

Some dependencies could not be looked up. Check the warning logs for more information.


Release Notes

dustin/go-humanize (github.com/dustin/go-humanize)

v1.0.1

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@openshift-ci openshift-ci Bot requested review from ciaranRoche and gdbranco April 6, 2025 23:20
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 6, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 6, 2025

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hunterkepley
Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 11, 2025
@hunterkepley
Copy link
Copy Markdown
Contributor

/retest-required

@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-dustin-go-humanize-1.x branch 22 times, most recently from 66b5327 to 6c2a492 Compare April 27, 2025 20:40
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-dustin-go-humanize-1.x branch 24 times, most recently from 692a93c to 0255e9c Compare May 5, 2025 16:47
@gdbranco
Copy link
Copy Markdown
Contributor

gdbranco commented May 8, 2025

@hunterkepley for the auto bumps from konflux to work in rosa cli the PR needs to include go mod vendor

@hunterkepley
Copy link
Copy Markdown
Contributor

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 13, 2025

@red-hat-konflux[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test 932705c link true /test test
ci/prow/commits 932705c link true /test commits

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7e58d6bb-8f85-4391-9d4e-87dc749879e5

📥 Commits

Reviewing files that changed from the base of the PR and between 1835c3f and 04cff81.

⛔ Files ignored due to path filters (9)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/dustin/go-humanize/.travis.yml is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/dustin/go-humanize/README.markdown is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/dustin/go-humanize/bigbytes.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/dustin/go-humanize/commaf.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/dustin/go-humanize/ftoa.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/dustin/go-humanize/number.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/dustin/go-humanize/si.go is excluded by !vendor/**, !**/vendor/**
  • vendor/modules.txt is excluded by !vendor/**, !**/vendor/**
📒 Files selected for processing (1)
  • go.mod

📝 Walkthrough

Walkthrough

This change updates the github.com/dustin/go-humanize dependency in go.mod from version v1.0.0 to v1.0.1. The update is a minor version increment affecting only the dependency declaration, with no modifications to code files or public APIs.

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete against the provided template. It omits required sections like PR Summary, Detailed Description, Type of Change checkbox, Test Steps, and Developer Verification Checklist, instead providing only an auto-generated dependency update table from Renovate/MintMaker. Add the required template sections, particularly: PR Summary, Detailed Description of Issue, Type of Change (chore/build), Test Steps, and complete the Developer Verification Checklist including mention of running go mod vendor per reviewer feedback.
Single Node Openshift (Sno) Test Compatibility ⚠️ Warning PR adds 270 test files with Ginkgo e2e tests making multi-node assumptions (autoscaler, machine pool scaling, node pool ops) without SNO protection. Add [Skipped:SingleReplicaTopology] labels or IsSingleNode checks to: rosa_autoscaler_test.go, hcp_machine_pool_test.go, test_rosacli_node_pool.go and other multi-node tests.
✅ Passed checks (10 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically identifies the main change: updating the go-humanize module dependency from v1.0.0 to v1.0.1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR is a dependency version bump (go-humanize v1.0.0→v1.0.1) with no modifications to test files or Ginkgo test declarations. Check not applicable.
Test Structure And Quality ✅ Passed Custom check for Ginkgo test code quality is not applicable - PR only updates go.mod dependency version for go-humanize, no test code modifications.
Microshift Test Compatibility ✅ Passed PR updates go.mod in ROSA CLI (not openshift/origin). Test files added are for CLI integration testing, not Ginkgo e2e tests. MicroShift check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR is a simple dependency bump (go-humanize v1.0.0→v1.0.1). No deployment manifests, operators, or scheduling constraints introduced. Check is not applicable to CLI dependency updates.
Ote Binary Stdout Contract ✅ Passed PR only updates go-humanize version in go.mod with no code changes. OTE Stdout Contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR updates go.mod to bump github.com/dustin/go-humanize from v1.0.0 to v1.0.1. The custom check applies only to new Ginkgo e2e tests, which this PR does not add.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/master/github.com-dustin-go-humanize-1.x

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot]
Once this PR has been reviewed and has the lgtm label, please assign olucasfreitas for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants