Update Konflux references#2900
Conversation
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
0d691c0 to
d4d3154
Compare
d4d3154 to
4bbd41f
Compare
|
/ok-to-test |
84884d4 to
bf5bf5d
Compare
60043d7 to
3244bb3
Compare
|
/lgtm |
6 similar comments
3244bb3 to
51c2c04
Compare
|
New changes are detected. LGTM label has been removed. |
51c2c04 to
bd8659a
Compare
bd8659a to
a06387c
Compare
a06387c to
38ea1ea
Compare
9d8cf38 to
8869e08
Compare
8869e08 to
12482e3
Compare
59886e8 to
9ed2968
Compare
9ed2968 to
0bd2aa2
Compare
0bd2aa2 to
7d84d65
Compare
7d84d65 to
ab5b45e
Compare
ab5b45e to
8847029
Compare
8847029 to
8add80d
Compare
8add80d to
288a1b0
Compare
288a1b0 to
f33725f
Compare
f33725f to
18f6a58
Compare
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdated four Tekton PipelineRun YAMLs under .tekton: refreshed many Tekton taskRef bundle image digests/versions, replaced explicit Changes
Sequence Diagram(s)sequenceDiagram
participant PR as PipelineRun
participant BI as build-image-index
participant BS as build-source-image
participant SAST as SAST/Coverity tasks
participant Reg as Image Registry
PR->>BI: start task
BI-->>PR: results: IMAGE_URL, IMAGE_DIGEST
PR->>BS: start with BINARY_IMAGE=IMAGE_URL, BINARY_IMAGE_DIGEST=IMAGE_DIGEST
BS->>Reg: push source/binary image (uses IMAGE_URL)
PR->>SAST: start with image-digest=IMAGE_DIGEST
SAST->>Reg: scan image by digest
Estimated code review effortHigh | ⏱️ ~20–30 minutes 🚥 Pre-merge checks | ✅ 11 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hunterkepley, red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
9ab05bc to
00ff6fb
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
.tekton/rosa-cli-e2e-test-push.yaml (1)
26-27:⚠️ Potential issue | 🟠 MajorNormalize the Dockerfile path for
buildah-oci-ta:0.9.The buildah-oci-ta:0.9 task contract requires the
dockerfileparameter to be a path relative to the git repository root./images/Dockerfile.konfluxis an absolute path and will fail at runtime. Change it toimages/Dockerfile.konflux.Suggested fix
- name: dockerfile - value: /images/Dockerfile.konflux + value: images/Dockerfile.konfluxAlso applies to
.tekton/rosa-cli-e2e-test-pull-request.yaml(same parameter at the same lines).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.tekton/rosa-cli-e2e-test-push.yaml around lines 26 - 27, The dockerfile parameter for the buildah-oci-ta:0.9 task is set to an absolute path ("/images/Dockerfile.konflux") which violates the task contract; update the dockerfile parameter value to a repository-relative path "images/Dockerfile.konflux" wherever the buildah-oci-ta:0.9 task is used (both occurrences mentioned) so the task receives a git-root-relative path instead of an absolute path..tekton/rosa-cli-e2e-test-pull-request.yaml (1)
29-30:⚠️ Potential issue | 🟠 MajorUse a repo-relative Dockerfile path before taking
buildah-oci-ta:0.9.The
0.9migration requiresdockerfileto be relative to the git repository root. This pipeline passes/images/Dockerfile.konfluxwith a leading slash, which violates the documented contract. The correct path should beimages/Dockerfile.konflux.Suggested fix
- name: dockerfile - value: /images/Dockerfile.konflux + value: images/Dockerfile.konflux🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.tekton/rosa-cli-e2e-test-pull-request.yaml around lines 29 - 30, Update the dockerfile value to be repository-relative by removing the leading slash: locate the dockerfile field in the Tekton step (the key named "dockerfile" in .tekton/rosa-cli-e2e-test-pull-request.yaml) and change its value from "/images/Dockerfile.konflux" to "images/Dockerfile.konflux" so it conforms to the buildah-oci-ta:0.9 contract.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.tekton/rosa-cli-e2e-test-pull-request.yaml:
- Around line 29-30: Update the dockerfile value to be repository-relative by
removing the leading slash: locate the dockerfile field in the Tekton step (the
key named "dockerfile" in .tekton/rosa-cli-e2e-test-pull-request.yaml) and
change its value from "/images/Dockerfile.konflux" to
"images/Dockerfile.konflux" so it conforms to the buildah-oci-ta:0.9 contract.
In @.tekton/rosa-cli-e2e-test-push.yaml:
- Around line 26-27: The dockerfile parameter for the buildah-oci-ta:0.9 task is
set to an absolute path ("/images/Dockerfile.konflux") which violates the task
contract; update the dockerfile parameter value to a repository-relative path
"images/Dockerfile.konflux" wherever the buildah-oci-ta:0.9 task is used (both
occurrences mentioned) so the task receives a git-root-relative path instead of
an absolute path.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 0f590e9e-055d-4b30-b665-9b54817a58f1
📒 Files selected for processing (4)
.tekton/rosa-cli-e2e-test-pull-request.yaml.tekton/rosa-cli-e2e-test-push.yaml.tekton/rosa-pull-request.yaml.tekton/rosa-push.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- .tekton/rosa-pull-request.yaml
00ff6fb to
dc49b1c
Compare
dc49b1c to
f491cb3
Compare
|
@red-hat-konflux[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
f491cb3 to
b3ae502
Compare
This PR contains the following updates:
0.1→0.30.1→0.30.4→0.90.2→0.30.2→0.30b35292→8b501445d63b92→e78d0d30.1→0.2302828e→9c300729709088→13d49df0.2→0.40.2→0.30.1→0.3c0798ff→d4e34990.2→0.37c845b1→e92d00ea591675→c4ef47e0.3→0.49a6ec55→8f3ecbe0.1→0.40.2→0.404f15cb→a7346ed0.2→0.3Release Notes
konflux-ci/build-definitions (quay.io/konflux-ci/tekton-catalog/task-apply-tags)
v0.30.1and0.2versions.konflux-ci/build-definitions (quay.io/konflux-ci/tekton-catalog/task-build-image-index)
v0.3Changed
konflux-build-clifor the build step instead of an inline bashimplementation. This provides more robust error handling and simplified maintenance.
ALWAYS_BUILD_INDEXisfalseand multiple images are provided, the task nowcreates an image index instead of failing. The previous behavior (failing with an error)
was not useful.
Removed
COMMIT_SHAparameter (was not used by the task implementation)IMAGE_EXPIRES_AFTERparameter (was not used by the task implementation)Added
konflux-ci/build-definitions (quay.io/konflux-ci/tekton-catalog/task-buildah-oci-ta)
v0.9Fixed
--failflag and error handling on the
curlcall that retrieves the SSH key from the OTP server.v0.8Fixed
for ARM architectures (e.g.,
linux/arm/v7orlinux/arm64/v8instead of justlinux/armor
linux/arm64).v0.7Added
konflux-ci/konflux-test-tasks (quay.io/konflux-ci/tekton-catalog/task-clair-scan)
v0.3Changed
quay.io/konflux-ci/oras:latestimage withquay.io/konflux-ci/task-runner:1.5.0in the oci-attach-report step.konflux-ci/build-definitions (quay.io/konflux-ci/tekton-catalog/task-init)
v0.4sast-target-dirswith invalid attributes from PipelineRun.spec.paramsdefinitionv0.3image-url,rebuildandskip-checksbuildkonflux-ci/build-definitions (quay.io/konflux-ci/tekton-catalog/task-prefetch-dependencies-oci-ta)
v0.3enable-package-registry-proxyparameter to enable use of the package registry proxy when prefetching dependencies.SERVICE_CA_TRUST_CONFIG_MAP_NAMEandSERVICE_CA_TRUST_CONFIG_MAP_KEYparameters to mount the OpenShift service CA for verifying TLS connections to in-cluster services such as the package registry proxy.konflux-ci/build-definitions (quay.io/konflux-ci/tekton-catalog/task-push-dockerfile-oci-ta)
v0.3Fixed
v0.2Removed
Configuration
📅 Schedule: Branch creation - Between 05:00 AM and 11:59 PM, only on Saturday ( * 5-23 * * 6 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.