Skip to content

OCM-21663 | feat: Allow min-replicas=0 for HCP nodepool autoscaling#3175

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
jhjaggars:allow-min-zero-replicas-hcp-nodepool
Feb 27, 2026
Merged

OCM-21663 | feat: Allow min-replicas=0 for HCP nodepool autoscaling#3175
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
jhjaggars:allow-min-zero-replicas-hcp-nodepool

Conversation

@jhjaggars
Copy link
Copy Markdown
Contributor

Updated CLI validation to allow minimum of 0 replicas for HCP nodepool autoscaling, matching the relaxed API constraints for customers with that capability enabled.

Changes:

  • Updated validation in pkg/machinepool/machinepool.go to allow min >= 0
  • Updated interactive validator in pkg/machinepool/helper.go for HCP
  • Updated unit tests to verify min=0 succeeds and negative values fail
  • Added comprehensive HCP-specific test coverage in helper_test.go
  • Updated E2E tests to expect min=0 to succeed

The changes align HCP nodepool validation with Classic machinepool behavior while maintaining all other safety constraints (negative values still rejected, multi-AZ multiples of 3 still enforced).

🤖 Generated with Claude Code

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 13, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jhjaggars jhjaggars changed the title OCM-XXXXX | feat: Allow min-replicas=0 for HCP nodepool autoscaling OCM-21663 | feat: Allow min-replicas=0 for HCP nodepool autoscaling Jan 13, 2026
@jhjaggars jhjaggars marked this pull request as ready for review January 13, 2026 18:46
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2026
@jhjaggars jhjaggars force-pushed the allow-min-zero-replicas-hcp-nodepool branch from cd3e4e0 to 5dee9f4 Compare January 14, 2026 16:16
@jhjaggars
Copy link
Copy Markdown
Contributor Author

/retest

Comment thread pkg/machinepool/helper.go Outdated
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@jhjaggars jhjaggars force-pushed the allow-min-zero-replicas-hcp-nodepool branch from 372c115 to 63613b0 Compare February 26, 2026 21:00
@marcolan018
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhjaggars, marcolan018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2026
@marcolan018
Copy link
Copy Markdown
Contributor

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2026
@marcolan018
Copy link
Copy Markdown
Contributor

/retest

@olucasfreitas
Copy link
Copy Markdown
Contributor

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2026
@olucasfreitas
Copy link
Copy Markdown
Contributor

/retest

@openshift-merge-bot openshift-merge-bot Bot merged commit ed0251d into openshift:master Feb 27, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants