Make BGP jobs standard

[tssurya]

Summary by CodeRabbit

• Refactor

  • Consolidated and streamlined BGP variant registry configurations across multiple variant entries to improve consistency and maintainability.

• Chores

  • Updated job tier assignments for BGP-related variants, transitioning from candidate tier to standard tier designation.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c90e1912-2df2-489d-8fa6-1150ecf39ff0

📥 Commits

Reviewing files that changed from the base of the PR and between 60b66e6 and 0f34f74.

📒 Files selected for processing (2)

• pkg/variantregistry/ocp.go
• pkg/variantregistry/snapshot.yaml

---

Walkthrough

The PR updates BGP job tier mappings from candidate to standard. The configuration logic in ocp.go is modified to map BGP variants to the standard tier instead of candidate, and nine variant blocks in snapshot.yaml reflect this tier elevation.

Changes

BGP Job Tier Promotion

Layer / File(s)	Summary
Tier Mapping Logic pkg/variantregistry/ocp.go	BGP job tier handling updated: -ovn-bgp-virt entry replaced with -bgp- mapped to standard tier; candidate-tier mapping for -bgp- removed, now mapping to standard.
Manifest Data pkg/variantregistry/snapshot.yaml	Nine variant blocks updated with JobTier changed from candidate to standard, reflecting the new BGP tier mapping.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 17

✅ Passed checks (17 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Make BGP jobs standard' clearly and concisely describes the main change: promoting BGP-related jobs from candidate tier to standard tier across the codebase.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Go Error Handling	✅ Passed	No error handling code was modified in this PR. Changes are configuration-only: updating BGP job tier from candidate to standard in setJobTier function and snapshot.yaml. Check not applicable.
Sql Injection Prevention	✅ Passed	PR modifies BGP job tier classification and snapshot config. No SQL queries are constructed in changed code. Existing SQL uses safe parameterization with static config values, not user input.
Excessive Css In React Should Use Styles	✅ Passed	Custom check not applicable. PR modifies only Go code and YAML config files. No React components, JavaScript, or inline CSS styles present in changes.
Test Coverage For New Features	✅ Passed	PR adds new files with tests and updates generated data. ocp.go/ocp_test.go are new with 5 test functions. snapshot.yaml is generated configuration. Tests cover BGP changes indirectly.
Single Responsibility And Clear Naming	✅ Passed	PR only modifies tier mappings in setJobTier method. No new types, structs, methods, or generic names. Action-oriented method naming preserved. Single responsibility maintained.
Stable And Deterministic Test Names	✅ Passed	This PR contains no Ginkgo tests. The codebase uses standard Go testing framework with testify assertions, not Ginkgo. The check is not applicable.
Test Structure And Quality	✅ Passed	PR modifies non-test files only. Repository uses Go testing, not Ginkgo. Custom check for Ginkgo test quality is not applicable.
Microshift Test Compatibility	✅ Passed	This PR modifies job tier configurations in ocp.go and snapshot.yaml, not Ginkgo e2e tests. The check is designed for new e2e tests; no such tests exist in this PR.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR does not add new Ginkgo e2e tests. Changes are limited to variant registry configuration (ocp.go, snapshot.yaml) for BGP job tier mapping. SNO check not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies Sippy's job variant metadata (tier classifications), not Kubernetes pod scheduling. No deployment manifests or scheduling constraints are added.
Ote Binary Stdout Contract	✅ Passed	PR modifies the Sippy job analysis tool, not an OTE binary. Changes are to job tier mappings in a data-loading library and YAML config. No process-level stdout writes detected.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR modifies BGP job tier configurations in Sippy's variant registry. No new Ginkgo e2e tests are added. The custom check only applies when test code is added.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.1)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

🔧 Microsoft Presidio Analyzer (2.2.362)

pkg/variantregistry/snapshot.yaml

Microsoft Presidio Analyzer failed to scan this file

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tssurya
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment