Master submodule update 05 14#4096
Conversation
Update to openshift/ovn-kubernetes@a9a7b4e This commit was generated using hack/update_submodules.sh
This commit was generated using hack/update_submodules.sh
📝 WalkthroughWalkthroughThis pull request updates module dependencies across two areas. The Suggested reviewers
🚥 Pre-merge checks | ✅ 14 | ❌ 3❌ Failed checks (1 warning, 2 inconclusive)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrvaldes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ovn-kubernetes`:
- Line 1: The submodule entry for ovn-kubernetes references a non-existent
commit SHA (a9a7b4e7538cc49df30ee49ec2c4e2c3b98dffab); update the
.gitmodules/submodule pointer and commit to a valid upstream commit: verify the
correct SHA in the ovn-org/ovn-kubernetes upstream repo (or the correct fork),
correct any typos in the commit id, update the submodule URL in .gitmodules if
it points to the wrong repo, then run git submodule sync && git submodule update
--init --recursive to record and commit the new valid commit reference so the
repository no longer points to the missing SHA.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 38435b8b-05a7-44c7-add2-02990202f67e
⛔ Files ignored due to path filters (10)
go.sumis excluded by!**/*.sum,!go.sumvendor/github.com/openshift/api/config/v1/types_apiserver.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/types_kmsencryption.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.swagger_doc_generated.gois excluded by!vendor/**,!**/vendor/**,!**/zz_generated.*.go,!**/zz_generated*vendor/github.com/openshift/api/route/v1/generated.protois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/route/v1/types.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/route/v1/zz_generated.featuregated-crd-manifests.yamlis excluded by!vendor/**,!**/vendor/**,!**/zz_generated*vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/vaultapproleauthentication.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/vaultkmspluginconfig.gois excluded by!vendor/**,!**/vendor/**vendor/modules.txtis excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (2)
go.modovn-kubernetes
| @@ -1 +1 @@ | |||
| Subproject commit 22e9487ee7060a85cfe20886b73e11fce3249e36 | |||
| Subproject commit a9a7b4e7538cc49df30ee49ec2c4e2c3b98dffab | |||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the ovn-kubernetes submodule commit exists and check its metadata
COMMIT="a9a7b4e7538cc49df30ee49ec2c4e2c3b98dffab"
REPO="ovn-org/ovn-kubernetes"
# Check if commit exists in the upstream repo and get commit info
gh api "repos/${REPO}/commits/${COMMIT}" --jq '{
sha: .sha,
author: .commit.author.name,
date: .commit.author.date,
message: (.commit.message | split("\n")[0])
}' 2>/dev/null || echo "Commit not found or API error"
# Check which branches contain this commit
echo ""
echo "Branches containing this commit:"
gh api "repos/${REPO}/commits/${COMMIT}/branches-where-head" --jq '.[].name' 2>/dev/null || echo "Could not determine branches"Repository: openshift/windows-machine-config-operator
Length of output: 543
Commit SHA not found in ovn-kubernetes repository — this must be resolved before merge.
The submodule commit hash a9a7b4e7538cc49df30ee49ec2c4e2c3b98dffab does not exist in the upstream ovn-org/ovn-kubernetes repository. Verify:
- The correct commit SHA (check if there's a typo)
- Whether this commit exists in a fork or different repository
- That the .gitmodules URL points to the correct upstream
A submodule update pointing to a non-existent commit will break the build and Windows node networking support.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ovn-kubernetes` at line 1, The submodule entry for ovn-kubernetes references
a non-existent commit SHA (a9a7b4e7538cc49df30ee49ec2c4e2c3b98dffab); update the
.gitmodules/submodule pointer and commit to a valid upstream commit: verify the
correct SHA in the ovn-org/ovn-kubernetes upstream repo (or the correct fork),
correct any typos in the commit id, update the submodule URL in .gitmodules if
it points to the wrong repo, then run git submodule sync && git submodule update
--init --recursive to record and commit the new valid commit reference so the
repository no longer points to the missing SHA.
|
/lgtm |
|
/override ci/prow/vsphere-e2e-operator |
|
@jrvaldes: Overrode contexts on behalf of jrvaldes: ci/prow/vsphere-e2e-operator DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jrvaldes: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary by CodeRabbit