Skip to content

[vendor] bump x/crypto to v0.51.0#4097

Open
jrvaldes wants to merge 1 commit into
openshift:masterfrom
jrvaldes:bump-lib-3
Open

[vendor] bump x/crypto to v0.51.0#4097
jrvaldes wants to merge 1 commit into
openshift:masterfrom
jrvaldes:bump-lib-3

Conversation

@jrvaldes
Copy link
Copy Markdown
Contributor

@jrvaldes jrvaldes commented May 14, 2026

Summary by CodeRabbit

  • Chores
    • Updated Go standard library dependencies to their latest compatible versions, including cryptography, networking, system interfaces, terminal support, and text processing modules, to improve application security, system stability, and overall platform performance.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3bb9722a-8a8c-45d8-9d15-13a86796b2f1

📥 Commits

Reviewing files that changed from the base of the PR and between e288f04 and 7129dde.

⛔ Files ignored due to path filters (19)
  • go.sum is excluded by !**/*.sum, !go.sum
  • vendor/golang.org/x/net/http2/hpack/tables.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/transport.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_other_arm64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_windows_arm64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/zcpu_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/affinity_linux.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/mkall.sh is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/syscall_linux.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/syscall_linux_arm.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/syscall_linux_arm64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/syscall_linux_loong64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/syscall_linux_riscv64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsyscall_linux.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/windows/syscall_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/windows/types_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/windows/zsyscall_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/modules.txt is excluded by !vendor/**, !**/vendor/**
📒 Files selected for processing (1)
  • go.mod

📝 Walkthrough

Walkthrough

This pull request updates multiple Go standard library dependencies in go.mod across two separate requirement blocks. Direct dependencies golang.org/x/crypto and golang.org/x/sys receive minor version bumps to v0.51.0 and v0.44.0 respectively. Concurrently, indirect dependencies golang.org/x/net, golang.org/x/term, and golang.org/x/text are bumped to v0.53.0, v0.43.0, and v0.37.0 respectively. All version increments are patch or minor releases. The total changeset impacts five lines across the module file with no alterations to module structure or other dependencies.

🚥 Pre-merge checks | ✅ 17
✅ Passed checks (17 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary change: bumping golang.org/x/crypto to v0.51.0, though it omits the concurrent updates to four other x/* packages also included in this changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Go Best Practices & Build Tags ✅ Passed PR is a dependency version bump (go.mod only, +5/-5 lines). No source code changes present. The custom check for Go error handling and build tags is not applicable to pure dependency management PRs.
Security: Secrets, Ssh & Csr ✅ Passed All security checks passed: secrets not logged, SSH sessions properly closed with defer, SFTP resources cleaned after transfer, CSR approvals validate node identity and certificate specs.
Kubernetes Controller Patterns ✅ Passed PR updates only go.mod dependency versions. Custom check for Kubernetes controller patterns is inapplicable since no controller code was modified—only dependency versions were bumped.
Windows Service Management ✅ Passed PR is a dependency version bump only affecting go.mod. No Windows service management code was modified, so custom check is not applicable to this PR.
Platform-Specific Requirements ✅ Passed This PR updates Go dependencies only. Platform-specific requirements (Azure 15-char machine names, vSphere prerequisites, etc.) are already documented in the codebase and unaffected by this change.
Stable And Deterministic Test Names ✅ Passed PR only modifies go.mod dependency versions. No test files or Ginkgo test declarations are added or modified. The check for stable test names is not applicable to this dependency update PR.
Test Structure And Quality ✅ Passed Custom check for Ginkgo test quality is not applicable to this PR. The codebase uses standard Go testing, not Ginkgo. No Ginkgo tests exist to review.
Microshift Test Compatibility ✅ Passed PR updates Go dependencies and adds standard Go tests (t.Run), not Ginkgo tests. Custom check applies only to Ginkgo patterns (It/Describe/Context).
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests added. This PR only updates Go module dependencies in go.mod. The SNO check applies only when new Ginkgo tests are introduced.
Topology-Aware Scheduling Compatibility ✅ Passed Check not applicable. PR only bumps golang.org/x/* dependency versions in go.mod. No manifests, operator code, or controllers modified—no scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed OTE binary (ote/cmd/wmco-tests-ext/main.go) has no stdout writes in main(). No fmt.Print, klog, or log calls. Dependency updates don't introduce stdout side effects.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only updates dependency versions in go.mod. No new Ginkgo e2e tests are added, so the IPv6/disconnected network compatibility check does not apply.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested a review from mansikulkarni96 May 14, 2026 15:33
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

@jrvaldes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/wicd-unit-vsphere 7129dde link true /test wicd-unit-vsphere
ci/prow/aws-e2e-operator 7129dde link true /test aws-e2e-operator
ci/prow/vsphere-e2e-operator 7129dde link true /test vsphere-e2e-operator
ci/prow/vsphere-proxy-e2e-operator 7129dde link true /test vsphere-proxy-e2e-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant