Skip to content

Revert rabbitmq pods memory limits#731

Open
lmiccini wants to merge 2 commits into
openstack-k8s-operators:mainfrom
lmiccini:revert-rmq-memory-limits
Open

Revert rabbitmq pods memory limits#731
lmiccini wants to merge 2 commits into
openstack-k8s-operators:mainfrom
lmiccini:revert-rmq-memory-limits

Conversation

@lmiccini
Copy link
Copy Markdown
Contributor

@lmiccini lmiccini commented Mar 31, 2026 •
edited
Loading

Supersedes #730

Jira: https://redhat.atlassian.net/browse/OSPCIX-1310

lmiccini and others added 2 commits March 31, 2026 08:44
@lmiccini
Revert "Increase rabbitmq pods memory limits"
e06e339
@lmiccini @claude
Remove rabbitmq memory resource patches from multi-namespace-skmo
9522837 
The base openstackcontrolplane.yaml no longer has rabbitmq resource
limits after the revert, so these replace patches fail with
"missing value". Remove them since the base no longer sets explicit
resource limits.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@lmiccini lmiccini requested a review from a team as a code owner March 31, 2026 06:44
@openshift-ci openshift-ci Bot requested review from fultonj and karelyatin March 31, 2026 06:45
@openshift-ci openshift-ci Bot added the lgtm label Mar 31, 2026
karelyatin
karelyatin approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@karelyatin karelyatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arxcruz, karelyatin, lmiccini
Once this PR has been reviewed and has the lgtm label, please assign leifmadsen for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abays
Copy link
Copy Markdown
Contributor

abays commented Apr 6, 2026

@lmiccini Are we going ahead with this revert? Just curious because the weekly architecture PR review is this morning and we'd like to either merge this or switch to draft if we're still unsure about the way forward.

@fultonj
Copy link
Copy Markdown
Contributor

fultonj commented Apr 6, 2026

/lgtm

@lmiccini
Copy link
Copy Markdown
Contributor Author

lmiccini commented Apr 7, 2026

thanks @abays let's hold for now, uniepsilon was fixed by bumping the ram of the workers from 32 to 40gb, let's see what the consensus is before merging this.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 23, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arxcruz arxcruz arxcruz approved these changes

@karelyatin karelyatin karelyatin approved these changes

@fultonj fultonj Awaiting requested review from fultonj

Assignees

@arxcruz arxcruz

@fultonj fultonj

@karelyatin karelyatin

Labels

do-not-merge/hold lgtm needs-rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lmiccini @abays @fultonj @arxcruz @karelyatin