nova04delta: fix preprovisioning network data for BMO#753
Open
bogdando wants to merge 1 commit into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bogdando The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
BMO reads preprovisioning network data from the Secret referenced by BareMetalHost.spec.preprovisioningNetworkDataName and expects the data under the 'networkData' key. Previously the BMH had no preprovisioningNetworkDataName (the secret was created but orphaned) and the values used 'nmstate' as the key. This did not surface because BMO never attempted to read the unreferenced secret. - baremetalhosts.yaml: add preprovisioningNetworkDataName pointing to the co-located edpm-compute-0-preprovision-network-data Secret. - values.yaml: rename the key from 'nmstate' to 'networkData' so the kustomize replacement produces a Secret with the key BMO reads. Generated-by: claude-4.6-opus-high Signed-off-by: Bohdan Dobrelia <bdobreli@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BMO reads preprovisioning network data from
the Secret referenced by BareMetalHost.spec.preprovisioningNetworkDataName and expects the data under the 'networkData' key.
Previously the BMH had no preprovisioningNetworkDataName (the secret was created but orphaned) and the values used 'nmstate' as the key. This did not surface because BMO never attempted to read the unreferenced secret.
Generated-by: claude-4.6-opus-high