[SKMO] Add cinderBackup kustomize replacements#758
Open
lkuchlan wants to merge 1 commit into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lkuchlan The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The cinderBackup configuration was added to service-values.yaml but the kustomization.yaml files were missing the replacement rules to apply it to the OpenStackControlPlane CR. Without these, the base CR default of replicas: 0 is used and cinder-backup is never deployed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lkuchlan
force-pushed
the
skmo-cinder-backup-kustomize-fix
branch
from
3d213d8 to
9704de2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cinderBackup.replicasandcinderBackup.customServiceConfigin both control-plane and control-plane2cinderBackupvalues inservice-values.yaml(added in [SKMO] Enable Cinder Backup with Swift backend #738) are never applied to the OpenStackControlPlane CR, leaving the base default ofreplicas: 0Test plan
kustomize buildsucceeds for both control-plane and control-plane2🤖 Generated with Claude Code