Skip to content

[multiple] Consolidate operator_namespace var to group_vars #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
amartyasinha wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[multiple] Consolidate operator_namespace var to group_vars #3537

amartyasinha wants to merge 1 commit into from
+9 −19

Conversation

@amartyasinha
Copy link
Contributor

@amartyasinha amartyasinha commented Dec 5, 2025 •
edited
Loading

Move all the definitions and hardcoding of operator_namespace so that it can be easily changed and managed from group_vars.

Depends-On: #3542

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rebtoor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amartyasinha amartyasinha force-pushed the operator_ns branch 2 times, most recently from 253b907 to eb73450 Compare December 5, 2025 10:25
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 5, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/779a94a88ea145dd967a36dc9363e98f

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 10m 37s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 29m 24s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 10s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 1h 52m 04s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 30s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 44s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 08s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 09s
✔️ build-push-container-cifmw-client SUCCESS in 19m 54s
✔️ cifmw-molecule-kustomize_deploy SUCCESS in 4m 33s
✔️ cifmw-molecule-os_must_gather SUCCESS in 27m 32s
✔️ cifmw-molecule-run_hook SUCCESS in 3m 31s
❌ cifmw-molecule-set_openstack_containers FAILURE in 27m 20s
✔️ cifmw-molecule-update SUCCESS in 4m 52s

@amartyasinha
Copy link
Contributor Author

amartyasinha commented Dec 5, 2025

recheck

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 5, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/940fdaed373546a18cf95179a7b9e081

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 50m 43s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 29m 13s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 36m 46s
❌ cifmw-crc-podified-edpm-baremetal-minor-update RETRY_LIMIT in 19m 19s
✔️ cifmw-pod-zuul-files SUCCESS in 23m 13s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 48s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 54s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 02s
✔️ build-push-container-cifmw-client SUCCESS in 16m 40s
✔️ cifmw-molecule-kustomize_deploy SUCCESS in 4m 18s
✔️ cifmw-molecule-os_must_gather SUCCESS in 26m 21s
✔️ cifmw-molecule-run_hook SUCCESS in 3m 36s
❌ cifmw-molecule-set_openstack_containers FAILURE in 23m 12s
✔️ cifmw-molecule-update SUCCESS in 5m 02s

@amartyasinha amartyasinha force-pushed the operator_ns branch 2 times, most recently from 57c8963 to 5853575 Compare December 8, 2025 06:19
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 8, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cd367261e4fc44aba3a527a1c07888f2

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 19m 52s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 26m 03s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 34m 43s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 05m 26s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 35s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 10s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 01s
✔️ cifmw-architecture-validate-hci SUCCESS in 5m 10s
✔️ build-push-container-cifmw-client SUCCESS in 19m 58s
✔️ cifmw-molecule-kustomize_deploy SUCCESS in 4m 28s
✔️ cifmw-molecule-os_must_gather SUCCESS in 25m 07s
✔️ cifmw-molecule-run_hook SUCCESS in 3m 33s
❌ cifmw-molecule-set_openstack_containers FAILURE in 26m 32s
✔️ cifmw-molecule-update SUCCESS in 4m 53s

@amartyasinha
Copy link
Contributor Author

amartyasinha commented Dec 11, 2025

recheck

@github-actions
Copy link

github-actions bot commented Dec 27, 2025

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 27, 2025
@github-actions github-actions bot removed the Stale label Dec 28, 2025
@amartyasinha amartyasinha marked this pull request as ready for review January 5, 2026 06:23
@amartyasinha amartyasinha requested a review from a team January 6, 2026 10:01
@amartyasinha
[multiple] Consolidate operator_namespace var to group_vars
c436ec8 
Move all the definitions and hardcoding of operator_namespace so that it can be easily changed and managed from group_vars.

Signed-off-by: Amartya Sinha <amsinha@redhat.com>
@amartyasinha
Copy link
Contributor Author

amartyasinha commented Jan 7, 2026

zuul gate jobs were stuck for unknown reason. this force commit adds nothing, just meant to retrigger the jobs.

@brjackma
Copy link
Contributor

brjackma commented Jan 7, 2026

Looks like the checks are affected by the known issue at the moment. The changes look good and I'll be happy to approve once the issues outside your control are resolved

@amartyasinha
Copy link
Contributor Author

amartyasinha commented Jan 7, 2026

recheck

brjackma
brjackma approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@brjackma brjackma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously reviewed and approving for when checks pass as no real changes have occurred since previous pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evallesp evallesp evallesp approved these changes

@brjackma brjackma brjackma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amartyasinha @brjackma @evallesp @openshift-merge-robot