Skip to content

Add additional parameter for horizontest#3897

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
HanzJas:add_horizon_param_skmo
May 13, 2026
Merged

Add additional parameter for horizontest#3897
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
HanzJas:add_horizon_param_skmo

Conversation

@HanzJas
Copy link
Copy Markdown
Contributor

@HanzJas HanzJas commented Apr 30, 2026

This commit add extra parameter for horizontest in order to modify projecttext xpath based on upstream and downstream dashboard theme.

@HanzJas
[test_operator] Add additional parameter for horizontest
0990380 
This commit add extra parameter for horizontest in order to modify
projecttext xpath based on upstream and downstream dashboard theme.

Signed-off-by: Jan Jasek <jjasek@redhat.com>
@HanzJas HanzJas force-pushed the add_horizon_param_skmo branch from 62d1312 to 0990380 Compare April 30, 2026 11:46
@HanzJas HanzJas mentioned this pull request May 6, 2026
Merged
@HanzJas HanzJas requested a review from kstrenkova May 12, 2026 09:16
kstrenkova
kstrenkova approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kstrenkova kstrenkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@kstrenkova
Copy link
Copy Markdown
Contributor

kstrenkova commented May 12, 2026

recheck

rebtoor
rebtoor approved these changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@rebtoor rebtoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm label May 13, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rebtoor
Copy link
Copy Markdown
Contributor

rebtoor commented May 13, 2026

/override rdo/github-check

it seems this pr should have been rebased first

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

@rebtoor: Overrode contexts on behalf of rebtoor: rdo/github-check

Details

In response to this:

/override rdo/github-check

it seems this pr should have been rebased first

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit 829525c into openstack-k8s-operators:main May 13, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rebtoor rebtoor rebtoor approved these changes

@bshewale bshewale bshewale approved these changes

@kstrenkova kstrenkova kstrenkova approved these changes

Assignees

@rebtoor rebtoor

Labels

approved lgtm Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HanzJas @kstrenkova @rebtoor @bshewale