[DNM][env_op_images] Add unit tests for verify_pulled_report_crio

ci/playbooks/collections/ansible_collections/cifmw/general/plugins/modules/verify_pulled_report_crio.py

@@ -0,0 +1 @@
+../../../../../../../../plugins/modules/verify_pulled_report_crio.py

roles/env_op_images/tasks/verify_pulled_report_crio.yml

@@ -106,7 +106,7 @@
 
             - name: Enrich pulled report with CRI-O evidence
               when: _verify_crio_log_files.matched | int > 0
-              verify_pulled_report_crio:
+              cifmw.general.verify_pulled_report_crio:
                 report_path: "{{ cifmw_env_op_images_pulled_report_path }}"
                 log_dir: "{{ cifmw_env_op_images_crio_logs_dir }}"
                 output_path: "{{ cifmw_env_op_images_verified_report_path }}"

tests/unit/modules/test_verify_pulled_report_crio.py

@@ -0,0 +1,316 @@
+# Copyright: (c) 2025, Red Hat
+
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+from __future__ import absolute_import, division, print_function
+
+import os
+import tempfile
+
+import yaml
+
+from ansible_collections.cifmw.general.tests.unit.utils import (
+    AnsibleExitJson,
+    AnsibleFailJson,
+    ModuleBaseTestCase,
+    set_module_args,
+)
+from ansible_collections.cifmw.general.plugins.modules import (
+    verify_pulled_report_crio,
+)
+
+
+class TestVerifyPulledReportCrio(ModuleBaseTestCase):
+    def test_enriches_report_and_counts_cross_node(self):
+        """
+        GIVEN a pulled-images report with two digest entries across two nodes
+              and CRI-O logs showing each image pulled on its own node
+        WHEN  the module processes the report against the logs
+        THEN  it enriches every image with log evidence, identifies trusted
+              mirrors, and reports zero cross-node entries
+        """
+        report_data = {
+            "summary": {
+                "mirror_rules": [
+                    {"mirror": "mirror.registry.example:5000/ns"},
+                    {"mirror": "other.example/ns"},
+                ]
+            },
+            "images": [
+                {
+                    "image_id": (
+                        "quay.io/demo/app@sha256:"
+                        "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+                    ),
+                    "node": "node-a",
+                },
+                {
+                    "image_id": (
+                        "quay.io/demo/other@sha256:"
+                        "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"
+                    ),
+                    "node": "node-b",
+                },
+                {"image_id": "no-digest-here", "node": "node-a"},
+            ],
+        }
+
+        with tempfile.TemporaryDirectory() as td:
+            report_path = os.path.join(td, "pulled_images_report.yaml")
+            output_path = os.path.join(td, "verified.yaml")
+            log_a = os.path.join(td, "node-a.crio.log")
+            log_b = os.path.join(td, "node-b.crio.log")
+
+            with open(report_path, "w") as f:
+                yaml.safe_dump(
+                    report_data, f, default_flow_style=False, sort_keys=False
+                )
+
+            with open(log_a, "w") as f:
+                f.write(
+                    'level=info msg="Pulled image: '
+                    "mirror.registry.example:5000/ns/app@sha256:"
+                    "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+                    '"\n'
+                )
+
+            with open(log_b, "w") as f:
+                f.write(
+                    'level=info msg="Pulled image: '
+                    "quay.io/demo/other@sha256:"
+                    "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"
+                    '"\n'
+                )
+
+            set_module_args(
+                dict(
+                    report_path=report_path,
+                    output_path=output_path,
+                    log_paths=[log_a, log_b],
+                )
+            )
+
+            with self.assertRaises(AnsibleExitJson) as rst:
+                verify_pulled_report_crio.run_module()
+
+            result = rst.exception.args[0]
+            self.assertTrue(result["changed"])
+            self.assertEqual(result["log_files"], 2)
+            self.assertEqual(result["entries_with_digest"], 2)
+            self.assertEqual(result["cross_node_entries"], 0)
+            self.assertIn("node-a", result["nodes_with_evidence"])
+            self.assertIn("node-b", result["nodes_with_evidence"])
+            self.assertIn("mirror.registry.example:5000", result["trusted_mirrors"])
+
+            with open(output_path, "r") as f:
+                enriched = yaml.safe_load(f)
+
+            img0 = enriched["images"][0]
+            self.assertEqual(img0["log_evidence_node"], "node-a")
+            self.assertEqual(
+                img0["log_evidence_uri"],
+                "mirror.registry.example:5000/ns/app",
+            )
+            self.assertEqual(img0["node_verified_image_origin"], "mirror")
+
+            img1 = enriched["images"][1]
+            self.assertEqual(img1["log_evidence_node"], "node-b")
+            self.assertEqual(img1["log_evidence_uri"], "quay.io/demo/other")
+            self.assertEqual(img1["node_verified_image_origin"], "source")
+
+    def test_cross_node_match_increments_counter(self):
+        """
+        GIVEN a pulled-images report listing an image on node-a
+              and a CRI-O log that records the same digest on node-b
+        WHEN  the module processes the report against the logs
+        THEN  the cross_node_entries counter is incremented and the
+              evidence node is set to the log's node (node-b)
+        """
+        report_data = {
+            "summary": {"mirror_rules": [{"mirror": "mirror.example/ns"}]},
+            "images": [
+                {
+                    "image_id": (
+                        "quay.io/demo/app@sha256:"
+                        "cccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc"
+                    ),
+                    "node": "node-a",
+                }
+            ],
+        }
+
+        with tempfile.TemporaryDirectory() as td:
+            report_path = os.path.join(td, "pulled_images_report.yaml")
+            output_path = os.path.join(td, "verified.yaml")
+            log_b = os.path.join(td, "node-b.crio.log")
+
+            with open(report_path, "w") as f:
+                yaml.safe_dump(
+                    report_data, f, default_flow_style=False, sort_keys=False
+                )
+
+            with open(log_b, "w") as f:
+                f.write(
+                    'level=info msg="Pulled image: '
+                    "mirror.example/ns/app@sha256:"
+                    "cccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc"
+                    '"\n'
+                )
+
+            set_module_args(
+                dict(
+                    report_path=report_path,
+                    output_path=output_path,
+                    log_paths=[log_b],
+                )
+            )
+
+            with self.assertRaises(AnsibleExitJson) as rst:
+                verify_pulled_report_crio.run_module()
+
+            result = rst.exception.args[0]
+            self.assertEqual(result["entries_with_digest"], 1)
+            self.assertEqual(result["cross_node_entries"], 1)
+
+            with open(output_path, "r") as f:
+                enriched = yaml.safe_load(f)
+
+            img0 = enriched["images"][0]
+            self.assertEqual(img0["log_evidence_node"], "node-b")
+            self.assertEqual(img0["node_verified_image_origin"], "mirror")
+
+    def test_fails_when_no_log_files(self):
+        """
+        GIVEN an empty list of CRI-O log paths
+        WHEN  the module is invoked
+        THEN  it fails with an error indicating no log files were provided
+        """
+        set_module_args(
+            dict(
+                report_path="/tmp/in.yaml",
+                output_path="/tmp/out.yaml",
+                log_paths=[],
+            )
+        )
+
+        with self.assertRaises(AnsibleFailJson) as rst:
+            verify_pulled_report_crio.run_module()
+
+        self.assertIn("No CRI-O log files", rst.exception.args[0]["msg"])
+
+    def test_fails_when_log_file_unreadable(self):
+        """
+        GIVEN a log_paths entry that points to a non-existent file
+        WHEN  the module tries to open it
+        THEN  it fails with an error mentioning the file path
+        """
+        with tempfile.TemporaryDirectory() as td:
+            report_path = os.path.join(td, "report.yaml")
+            with open(report_path, "w") as f:
+                yaml.safe_dump(
+                    {"summary": {}, "images": []},
+                    f,
+                    default_flow_style=False,
+                )
+
+            missing_log = os.path.join(td, "ghost.crio.log")
+            set_module_args(
+                dict(
+                    report_path=report_path,
+                    output_path=os.path.join(td, "out.yaml"),
+                    log_paths=[missing_log],
+                )
+            )
+
+            with self.assertRaises(AnsibleFailJson) as rst:
+                verify_pulled_report_crio.run_module()
+
+            self.assertIn("Cannot read CRI-O log file", rst.exception.args[0]["msg"])
+            self.assertIn("ghost.crio.log", rst.exception.args[0]["msg"])
+
+    def test_fails_when_report_unreadable(self):
+        """
+        GIVEN a report_path that does not exist on disk
+        WHEN  the module tries to open it
+        THEN  it fails with an error mentioning the report path
+        """
+        with tempfile.TemporaryDirectory() as td:
+            log_path = os.path.join(td, "node-a.crio.log")
+            with open(log_path, "w") as f:
+                f.write("")
+
+            set_module_args(
+                dict(
+                    report_path=os.path.join(td, "no_such_report.yaml"),
+                    output_path=os.path.join(td, "out.yaml"),
+                    log_paths=[log_path],
+                )
+            )
+
+            with self.assertRaises(AnsibleFailJson) as rst:
+                verify_pulled_report_crio.run_module()
+
+            self.assertIn("Cannot read report", rst.exception.args[0]["msg"])
+
+    def test_fails_when_report_has_invalid_yaml(self):
+        """
+        GIVEN a report file whose contents are not valid YAML
+        WHEN  the module tries to parse it
+        THEN  it fails with an error about invalid YAML
+        """
+        with tempfile.TemporaryDirectory() as td:
+            report_path = os.path.join(td, "bad.yaml")
+            with open(report_path, "w") as f:
+                f.write("{{: not: valid: yaml: [}")
+
+            log_path = os.path.join(td, "node-a.crio.log")
+            with open(log_path, "w") as f:
+                f.write("")
+
+            set_module_args(
+                dict(
+                    report_path=report_path,
+                    output_path=os.path.join(td, "out.yaml"),
+                    log_paths=[log_path],
+                )
+            )
+
+            with self.assertRaises(AnsibleFailJson) as rst:
+                verify_pulled_report_crio.run_module()
+
+            self.assertIn("Invalid YAML in report", rst.exception.args[0]["msg"])
+
+    def test_fails_when_report_root_is_not_a_dict(self):
+        """
+        GIVEN a report file whose YAML root is a list instead of a mapping
+        WHEN  the module checks the structure
+        THEN  it fails with an error about the root type
+        """
+        with tempfile.TemporaryDirectory() as td:
+            report_path = os.path.join(td, "list.yaml")
+            with open(report_path, "w") as f:
+                yaml.safe_dump(
+                    ["item1", "item2"],
+                    f,
+                    default_flow_style=False,
+                )
+
+            log_path = os.path.join(td, "node-a.crio.log")
+            with open(log_path, "w") as f:
+                f.write("")
+
+            set_module_args(
+                dict(
+                    report_path=report_path,
+                    output_path=os.path.join(td, "out.yaml"),
+                    log_paths=[log_path],
+                )
+            )
+
+            with self.assertRaises(AnsibleFailJson) as rst:
+                verify_pulled_report_crio.run_module()
+
+            self.assertIn("Report root must be a mapping", rst.exception.args[0]["msg"])