Skip to content

[ci_gen_kustomize_values] fix: Preserve nodes config from architectur…#3916

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
mnietoji:fix/preserve-nfv-nodes-config
May 13, 2026
Merged

[ci_gen_kustomize_values] fix: Preserve nodes config from architectur…#3916
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
mnietoji:fix/preserve-nfv-nodes-config

Conversation

@mnietoji
Copy link
Copy Markdown
Contributor

@mnietoji mnietoji commented May 8, 2026

Extend the fix from fffa721 (HCI template) to all remaining NFV
templates. Preserve the complete node configuration (ansibleHost,
networks, fixedIP) from the architecture repository instead of
overwriting it with just hostName.

Affected templates: ovs-dpdk, ovs-dpdk-sriov, ovs-dpdk-sriov-ipv6,
sriov, ovs-dpdk-sriov-2nodesets, ovs-dpdk-sriov-ipv6-2nodesets,
and ovs-dpdk-sriov-networker.

Signed-off-by: Miguel Angel Nieto Jimenez mnietoji@redhat.com
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

mnietoji added a commit to mnietoji/architecture that referenced this pull request May 10, 2026
…rios

Define per-node networks with fixedIP in all NFV nodeset values so that
each compute node gets a known IP address on the ctlplane network.
Without this, nodes are generated with only hostName and the resulting
IP is unpredictable.

Extends the pattern already present in nfv-ovs-dpdk-sriov-hci to:
ovs-dpdk, ovs-dpdk-sriov, sriov, nfv-ovs-dpdk-sriov-2nodesets,
and nfv-ovs-dpdk-sriov-networker.

Depends-On: openstack-k8s-operators/ci-framework#3916

Signed-off-by: Miguel Angel Nieto Jimenez <mnietoji@redhat.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
evallesp
evallesp previously approved these changes May 11, 2026
Copy link
Copy Markdown
Contributor

@evallesp evallesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label May 11, 2026
@mnietoji mnietoji added documentation Improvements or additions to documentation do-not-merge/work-in-progress labels May 13, 2026
@mnietoji mnietoji force-pushed the fix/preserve-nfv-nodes-config branch from a506266 to ad748db Compare May 13, 2026 09:28
@openshift-ci openshift-ci Bot removed the lgtm label May 13, 2026
@mnietoji mnietoji removed documentation Improvements or additions to documentation do-not-merge/work-in-progress labels May 13, 2026
…e repo in all NFV templates

Extend the fix from fffa721 (HCI template) to all remaining NFV
templates. Preserve the complete node configuration (ansibleHost,
networks, fixedIP) from the architecture repository instead of
overwriting it with just hostName.

Affected templates: ovs-dpdk, ovs-dpdk-sriov, ovs-dpdk-sriov-ipv6,
sriov, ovs-dpdk-sriov-2nodesets, ovs-dpdk-sriov-ipv6-2nodesets,
and ovs-dpdk-sriov-networker.

Signed-off-by: Miguel Angel Nieto Jimenez <mnietoji@redhat.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@mnietoji mnietoji force-pushed the fix/preserve-nfv-nodes-config branch from ad748db to 417f963 Compare May 13, 2026 09:33
@brjackma
Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brjackma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit c6798e9 into openstack-k8s-operators:main May 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants