[ci_gen_kustomize_values] fix: Preserve nodes config from architectur…#3916
Merged
openshift-merge-bot[bot] merged 1 commit intoMay 13, 2026
Conversation
mnietoji
added a commit
to mnietoji/architecture
that referenced
this pull request
May 10, 2026
…rios Define per-node networks with fixedIP in all NFV nodeset values so that each compute node gets a known IP address on the ctlplane network. Without this, nodes are generated with only hostName and the resulting IP is unpredictable. Extends the pattern already present in nfv-ovs-dpdk-sriov-hci to: ovs-dpdk, ovs-dpdk-sriov, sriov, nfv-ovs-dpdk-sriov-2nodesets, and nfv-ovs-dpdk-sriov-networker. Depends-On: openstack-k8s-operators/ci-framework#3916 Signed-off-by: Miguel Angel Nieto Jimenez <mnietoji@redhat.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
a506266 to
ad748db
Compare
evallesp
approved these changes
May 13, 2026
…e repo in all NFV templates Extend the fix from fffa721 (HCI template) to all remaining NFV templates. Preserve the complete node configuration (ansibleHost, networks, fixedIP) from the architecture repository instead of overwriting it with just hostName. Affected templates: ovs-dpdk, ovs-dpdk-sriov, ovs-dpdk-sriov-ipv6, sriov, ovs-dpdk-sriov-2nodesets, ovs-dpdk-sriov-ipv6-2nodesets, and ovs-dpdk-sriov-networker. Signed-off-by: Miguel Angel Nieto Jimenez <mnietoji@redhat.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ad748db to
417f963
Compare
brjackma
approved these changes
May 13, 2026
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brjackma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c6798e9
into
openstack-k8s-operators:main
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the fix from fffa721 (HCI template) to all remaining NFV
templates. Preserve the complete node configuration (ansibleHost,
networks, fixedIP) from the architecture repository instead of
overwriting it with just hostName.
Affected templates: ovs-dpdk, ovs-dpdk-sriov, ovs-dpdk-sriov-ipv6,
sriov, ovs-dpdk-sriov-2nodesets, ovs-dpdk-sriov-ipv6-2nodesets,
and ovs-dpdk-sriov-networker.
Signed-off-by: Miguel Angel Nieto Jimenez mnietoji@redhat.com
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com