Increase queue limits to reflect modern machines #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When these limits were set in 2008 (a16d3b7) it would take a few minutes to clear through the dirty tile queue, giving it the ability to even out load over a few minute timescale, and let the work in the queue be done when the server is no longer busy. These days, a server can clear through 1000 metatiles in seconds, meaning the queue fills up nearly instantly and starts dropping tiles. Increasing these limits by 8x attempts to restore some of the old utility of the queue.
|
Is anything in unmerged #152 of 2017 possibly still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When these limits were set in 2008 (a16d3b7) it would take a few minutes to clear through the dirty tile queue, giving it the ability to even out load over a few minute timescale, and let the work in the queue be done when the server is no longer busy. These days, a server can clear through 1000 metatiles in seconds, meaning the queue fills up nearly instantly and starts dropping tiles.
Increasing these limits by 8x attempts to restore some of the old utility of the queue.
By my estimates, in 2008 a server might have been doing 5 metatiles/second, while now it's 100 metatiles/second.
If we were starting over, I wouldn't consider the gains of having the queue worth the additional code complexity.