Skip to content

Conversation

@hummeltech
Copy link
Collaborator

@hummeltech hummeltech commented May 28, 2025

This has unexpected effects for map section URI values which are parent paths of subsequent map section URIs.

E.g. for:

[map0]
uri=/map1/

[map1]
uri=/map1/1/

[map2]
uri=/map2/2/

Only map0 and map2 would be served as the uri for map1 is a path under the uri for map0.

Also, for:

[map0]
uri=/ # or no uri specification at all

[map1]
uri=/map1/1/

[map2]
uri=/map2/2/

Only map0 would be served as the uri for both map1 and map2 are paths under the uri for map0.

This pull request stops these from being allowed in renderd.conf files.

Resolves #27

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.52%. Comparing base (c4e3e62) to head (c4a1aa5).
⚠️ Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
src/renderd_config.c 92.59% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
- Coverage   81.54%   81.52%   -0.02%     
==========================================
  Files          24       24              
  Lines        5645     5689      +44     
==========================================
+ Hits         4603     4638      +35     
- Misses       1042     1051       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hummeltech hummeltech marked this pull request as draft May 28, 2025 22:06
@hummeltech hummeltech force-pushed the MapSections branch 2 times, most recently from fd9621e to 0841cec Compare May 29, 2025 16:36
@hummeltech hummeltech marked this pull request as ready for review May 29, 2025 16:55
@hummeltech hummeltech changed the title Disallow map section URIs which are starting substrings of subsequent map section URIs Disallow map section URI paths which are parents of subsequent map section URI paths May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mod_tile config parsing

2 participants