625 feat vpc version management #628
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
24
to
26
| subnet_id='1bc849dc-4426-455a-8207-fb5f726c6ff7', | ||
| endpoint_service_id='b002616f-f386-4da1-8118-04d5e090200f', | ||
| vpc_id='80a6ba4b-44d7-4c57-be40-5013a1e55273', |
Member
There was a problem hiding this comment.
all values are hardcoded, can you change it?
| attrs = { | ||
| 'name': lb_name, | ||
| 'description': 'ELB for VPCEP functional tests', | ||
| 'vip_subnet_cidr_id': _shared_subnet_id, |
Member
There was a problem hiding this comment.
are, you sure, that is correct parameter?
Contributor
Author
There was a problem hiding this comment.
which one you mean here?
vip_subnet_cidr_id exists in doc
https://docs.otc.t-systems.com/elastic-load-balancing/api-ref/apis_v3/load_balancer/creating_a_load_balancer.html#createloadbalancer
| self.assertIn(updated_name, fetched.service_name) | ||
| self.assertTrue(fetched.is_approval_enabled) | ||
|
|
||
| def test_delete_service(self): |
Member
There was a problem hiding this comment.
you can skip this test, because delete already in cleanup
anton-sidelnikov
requested changes
Jan 26, 2026
Member
anton-sidelnikov
left a comment
anton-sidelnikov
left a comment
There was a problem hiding this comment.
look at the comments
anton-sidelnikov
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.